Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Saved Object Service] Adds Repository Factory Provider #4244

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5c5de03 from #4149.

* Adds Repository Factory Provider

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
(cherry picked from commit 5c5de03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@zhongnansu zhongnansu self-assigned this Jun 5, 2023
@zhongnansu zhongnansu added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.9.0 labels Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #4244 (bb3e682) into 2.x (8af035d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              2.x    #4244      +/-   ##
==========================================
+ Coverage   66.36%   66.38%   +0.01%     
==========================================
  Files        3229     3229              
  Lines       62114    62121       +7     
  Branches     9616     9619       +3     
==========================================
+ Hits        41224    41241      +17     
+ Misses      18571    18560      -11     
- Partials     2319     2320       +1     
Flag Coverage Δ
Linux 66.31% <100.00%> (+<0.01%) ⬆️
Windows 66.33% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/server/legacy/legacy_service.ts 75.38% <ø> (ø)
src/core/server/plugins/plugin_context.ts 45.45% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 100.00% <ø> (ø)
...aved_objects/service/lib/scoped_client_provider.ts 100.00% <ø> (ø)
...core/server/saved_objects/saved_objects_service.ts 85.71% <100.00%> (+1.58%) ⬆️

... and 2 files with indirect coverage changes

@zhongnansu zhongnansu merged commit 0196d91 into 2.x Jun 6, 2023
@github-actions github-actions bot deleted the backport/backport-4149-to-2.x branch June 6, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants