[CCI] Add bluebird replaces for test/functional #4029

Nicksqain · 2023-05-15T10:32:54Z

Description

Issues Resolved

closes Eliminate Bluebird in favor of native async functionality #3662

Check List

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>

codecov · 2023-05-15T11:16:56Z

Codecov Report

Merging #4029 (8cc0403) into main (69b1854) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4029      +/-   ##
==========================================
+ Coverage   66.38%   66.43%   +0.05%     
==========================================
  Files        3229     3229              
  Lines       62067    62067              
  Branches     9598     9598              
==========================================
+ Hits        41201    41233      +32     
+ Misses      18557    18530      -27     
+ Partials     2309     2304       -5

Flag	Coverage Δ
Linux	`66.37% <ø> (-0.01%)`	⬇️
Windows	`66.38% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

ananzh

@Nicksqain thank you for the contribute. If you need some help to understand when need to add await, let me know or go to office hour~

ananzh · 2023-06-01T16:09:04Z

test/functional/page_objects/common_page.ts

 import expect from '@osd/expect';
 // @ts-ignore
 import fetch from 'node-fetch';
 import { FtrProviderContext } from '../ftr_provider_context';
 // @ts-ignore not TS yet
 import getUrl from '../../../src/test_utils/get_url';

+function delay(ms: number) {


As @AMoo-Miki mentioned in ur other PR, let's move delay func to @osd/utils

ananzh · 2023-06-01T16:09:25Z

test/functional/page_objects/login_page.ts

 import { FtrProviderContext } from '../ftr_provider_context';

+function delay(ms: number) {


Same as above comment

ananzh · 2023-06-01T16:22:25Z

test/functional/page_objects/management/saved_objects_page.ts

-          copySaveObjectsElement,
-        };
-      });
+      return await Promise.all(


await is not needed here. when you return a Promise from an async function, you don't need to use await.

ananzh · 2023-06-01T16:25:13Z

test/functional/page_objects/management/saved_objects_page.ts

-          inspectElement,
-        };
-      });
+      return await Promise.all(


Again, we only need to use await within the async function passing to map because we need to wait for each Promise to resolve before we return an object with their resolved values. But when returning from an async function, we could just return the Promise directly without using await.

ananzh · 2023-06-01T16:29:42Z

test/functional/page_objects/settings_page.ts

-      return await mapAsync(fieldNameCells, async (cell) => {
-        return (await cell.getVisibleText()).trim();
-      });
+      return await Promise.all(


same issue as above

ananzh · 2023-06-01T16:30:11Z

test/functional/page_objects/settings_page.ts

-      return await mapAsync(fieldNameCells, async (cell) => {
-        return (await cell.getVisibleText()).trim();
-      });
+      return await Promise.all(


ananzh · 2023-06-01T16:30:18Z

test/functional/page_objects/settings_page.ts

-      return await mapAsync(indexPatterns, async (index) => {
-        return await index.getVisibleText();
-      });
+      return await Promise.all(


ananzh · 2023-06-01T16:33:22Z

test/functional/services/lib/web_element_wrapper/web_element_wrapper.ts

@@ -55,6 +54,10 @@ const RETRY_CLICK_RETRY_ON_ERRORS = [
  'StaleElementReferenceError',
 ];

+function delay(ms: number) {


Nicksqain · 2023-06-01T16:41:16Z

@Nicksqain thank you for the contribute. If you need some help to understand when need to add await, let me know or go to office hour~

Thanks for reviewing the code!
Yes, I realised that I should just return all the promises, which are already asynchronous, that's my mistake. I saw await in the old lines and typed await :[

manasvinibs · 2023-06-13T23:01:14Z

test/functional/page_objects/management/saved_objects_page.ts

@@ -193,53 +192,55 @@ export function SavedObjectsPageProvider({ getService, getPageObjects }: FtrProv

    async getElementsInTable() {
      const rows = await testSubjects.findAll('~savedObjectsTableRow');


Also I don't think we need await here as well, do we? As Promise.all() function already waits for all the promises to resolve before returning, it will not have to wait for the await keyword to resolve before continuing and that way might be bit more efficient.

abbyhu2000 · 2023-07-25T19:18:41Z

Convert to draft for now, can be marked as ready once the comments are addressed. Thanks!

ananzh · 2024-07-25T16:20:40Z

@Nicksqain Due to an extended period without updates, we're going to close this issue for now. We appreciate your contribution and understand that priorities and availability can change. Please feel free to reopen this issue when you have the opportunity to revisit it. Thank you for your understanding.

Add bluebird replaces for test/functional

cbc6873

Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>

github-actions bot added the repeat-contributor label May 15, 2023

Nicksqain marked this pull request as ready for review May 16, 2023 16:00

Nicksqain requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu and manasvinibs as code owners May 16, 2023 16:00

abbyhu2000 self-assigned this May 16, 2023

abbyhu2000 added the OSCI Open Source Contributor Initiative label May 16, 2023

Merge branch 'main' into bluebird-test-functional

8cc0403

ananzh assigned ananzh and unassigned abbyhu2000 May 31, 2023

ananzh added v2.9.0 technical debt If not paid, jeapardizes long-term success and maintainability of the repository. backport 2.x labels May 31, 2023

ananzh requested changes Jun 1, 2023

View reviewed changes

joshuarrrr added the needs more info Requires more information from poster label Jun 13, 2023

manasvinibs reviewed Jun 13, 2023

View reviewed changes

manasvinibs added v2.10.0 and removed v2.9.0 labels Jul 5, 2023

abbyhu2000 marked this pull request as draft July 25, 2023 19:18

joshuarrrr removed backport 2.x v2.10.0 labels Aug 28, 2023

ananzh closed this Jul 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCI] Add bluebird replaces for test/functional #4029

[CCI] Add bluebird replaces for test/functional #4029

Nicksqain commented May 15, 2023

codecov bot commented May 15, 2023 •

edited

Loading

ananzh left a comment

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

ananzh Jun 1, 2023

Nicksqain commented Jun 1, 2023

manasvinibs Jun 13, 2023

abbyhu2000 commented Jul 25, 2023

ananzh commented Jul 25, 2024

		import { FtrProviderContext } from '../ftr_provider_context';

		function delay(ms: number) {

		@@ -193,53 +192,55 @@ export function SavedObjectsPageProvider({ getService, getPageObjects }: FtrProv

		async getElementsInTable() {
		const rows = await testSubjects.findAll('~savedObjectsTableRow');

[CCI] Add bluebird replaces for test/functional #4029

[CCI] Add bluebird replaces for test/functional #4029

Conversation

Nicksqain commented May 15, 2023

Description

Issues Resolved

Check List

codecov bot commented May 15, 2023 • edited Loading

Codecov Report

ananzh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nicksqain commented Jun 1, 2023

Choose a reason for hiding this comment

abbyhu2000 commented Jul 25, 2023

ananzh commented Jul 25, 2024

codecov bot commented May 15, 2023 •

edited

Loading