Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance grouping for context menu options #3924

Merged
merged 12 commits into from
May 24, 2023
Merged

enhance grouping for context menu options #3924

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b98934b
enhance grouping for context menu options
sikhote Apr 24, 2023
232fc03
change log
sikhote Apr 24, 2023
867978f
remove type export
sikhote Apr 24, 2023
41daddd
revert border and prevent destroy options
sikhote Apr 24, 2023
c5ce04d
Merge branch 'enhance-grouping-for-context-menu-options' of github.co…
sikhote May 15, 2023
967a8f1
revert destroy
sikhote May 15, 2023
575bae7
Merge branch 'enhance-grouping-for-context-menu-options' of github.co…
sikhote May 15, 2023
39f0f1b
revert getDisplayName changes
sikhote May 15, 2023
649b21a
Merge branch 'enhance-grouping-for-context-menu-options' of github.co…
sikhote May 21, 2023
a25cbc4
update comments for building panels
sikhote May 21, 2023
d9bf726
build panels tests and more comments
sikhote May 22, 2023
4c7fece
Merge branch 'main' into enhance-grouping-for-context-menu-options
joshuarrrr May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/embeddable/public/lib/embeddables/embeddable_factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ export interface EmbeddableFactory<
* Returns a display name for this type of embeddable. Used in "Create new... " options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps, I can change this comment to inform users that a React element is also supported here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this change? This is for the Create new button for embeddables right?

* in the add panel for containers.
*/
getDisplayName(): JSX.Element | string;
getDisplayName(): string;

/**
* If false, this type of embeddable can't be created with the "createNew" functionality. Instead,
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/ui_actions/public/util/presentable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export interface Presentable<Context extends object = object> {
/**
* Returns a title to be displayed to the user.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here for changing this comment to inform users that a React element is also supported here.

*/
getDisplayName(context: Context): JSX.Element | string;
getDisplayName(context: Context): string;

/**
* Returns tooltip text which should be displayed when user hovers this object.
Expand Down