Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Console] Fix updating of play and wrench button #3920

Closed
wants to merge 3 commits into from
Closed

[BUG][Console] Fix updating of play and wrench button #3920

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dfd67e
[BUG][Console] Fix updating of play and wrench button
kavilla Apr 21, 2023
2ad491b
Update release-notes/opensearch-dashboards.release-notes-2.7.0.md
kavilla Apr 22, 2023
89ca895
Update CHANGELOG.md
kavilla Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Console] Fix dev tool console autocomplete not loading issue ([#3775](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3775))
- [Console] Fix dev tool console run command with query parameter error ([#3813](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3813))
- Add clarifying tooltips to header navigation ([#3573](https://github.com/opensearch-project/OpenSearch-Dashboards/issues/3573))
- [Console] Fix dev tool console not updating action bar ([#3920](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3920))
kavilla marked this conversation as resolved.
Show resolved Hide resolved

### 🚞 Infrastructure

Expand Down
1 change: 1 addition & 0 deletions release-notes/opensearch-dashboards.release-notes-2.7.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- [Console] Fix/update documentation links in Dev Tools console ([#3724](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3724))
- [Console] Fix dev tool console autocomplete not loading issue ([#3775](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3775))
- [Console] Fix dev tool console run command with query parameter error ([#3813](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3813))
- [Console] Fix dev tool console not updating action bar ([#3920](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3920))
kavilla marked this conversation as resolved.
Show resolved Hide resolved
- [Table Visualization] Fix table rendering empty unused space ([#3797](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3797))
- [Table Visualization] Fix data table not adjusting height on the initial load ([#3816](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3816))
- [Timeline] Fix y-axis label color in dark mode ([#3698](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3698))
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/console/public/application/models/legacy_core_editor/legacy_core_editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@ export class LegacyCoreEditor implements CoreEditor {
} else {
if (topOrBottom === 'top') {
this.actions.style.bottom = 'auto';
this.actions.style.top = value;
this.actions.style.top = `${value}px`;
this.actions.style.visibility = 'visible';
} else {
this.actions.style.top = 'auto';
this.actions.style.bottom = value;
this.actions.style.bottom = `${value}px`;
this.actions.style.visibility = 'visible';
}
}
Expand Down Expand Up @@ -320,7 +320,7 @@ export class LegacyCoreEditor implements CoreEditor {
// elements are positioned relative to the editor's container
// pageY is relative to page, so subtract the offset
// from pageY to get the new top value
const offsetFromPage = this.editor.container.offsetTop;
const { top: offsetFromPage } = this.editor.container.getBoundingClientRect();
const startLine = range.start.lineNumber;
const startColumn = range.start.column;
const firstLine = this.getLineValue(startLine);
Expand Down