Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downgrade logic for branch in DocLinkService #3483

Merged
merged 14 commits into from
Mar 23, 2023
Merged

Add downgrade logic for branch in DocLinkService #3483

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9df87a5
feature: patch pkg.branch when needed
SuZhou-Joe Feb 22, 2023
f533c75
feat: update CHANGELOG.md
SuZhou-Joe Feb 22, 2023
730d694
feat: use buildVersion
SuZhou-Joe Feb 22, 2023
b09c3eb
Update src/dev/build/tasks/create_package_json_task.ts
SuZhou-Joe Feb 23, 2023
8f8521d
feat: pass ts type check
SuZhou-Joe Mar 3, 2023
59897b0
feat: move branch logic to runtime to restrict impact
SuZhou-Joe Mar 21, 2023
361eaf5
feat: update changelog
SuZhou-Joe Mar 21, 2023
a6c1f8a
Revert "feat: pass ts type check"
SuZhou-Joe Mar 21, 2023
6f97098
Revert "Update src/dev/build/tasks/create_package_json_task.ts "
SuZhou-Joe Mar 21, 2023
1dff042
Revert "feat: use buildVersion"
SuZhou-Joe Mar 21, 2023
35fff82
Revert "feature: patch pkg.branch when needed"
SuZhou-Joe Mar 21, 2023
20c04b0
feat: remove error message and update unit test
SuZhou-Joe Mar 21, 2023
2a698e3
feat: add default value
SuZhou-Joe Mar 21, 2023
f0d6198
feat: optimize code logic
SuZhou-Joe Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "feat: pass ts type check" 
This reverts commit 8f8521d.

Signed-off-by: suzhou <suzhou@amazon.com>
  • Loading branch information
@SuZhou-Joe
SuZhou-Joe committed Mar 21, 2023
commit a6c1f8add74e7c4bdf5b68154bc96e6a07d88815
2 changes: 1 addition & 1 deletion src/dev/build/tasks/create_package_json_task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const CreatePackageJson: Task = {
log.info(`Updating package.branch to ${branch}`);
} else {
const validDocPathsPattern = /^\d+\.\d+$/;
if (validDocPathsPattern.test(pkg.branch as string)) {
if (validDocPathsPattern.test(pkg.branch)) {
branch = pkg.branch;
} else {
// package version was not parsable and branch is unusable
Expand Down