Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Upgrade yarn version to be compatible with @openearch-project/opensearch #3465

Closed
wants to merge 2 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

@opensearch-trigger-bot opensearch-trigger-bot bot commented Feb 20, 2023

Backport d3fc27d from #3443.

Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would make sure to sign the last commit @zhongnansu or rebase onto the original commit.

Also, it appears that the OpenSearch JS bump caused a breaking change for downstream dependencies. And we have a revert commit on the way: 32944dd.

So probably best to hold off.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #3465 (ffb2f41) into 2.x (82c45c1) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              2.x    #3465   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3205     3205           
  Lines       61567    61567           
  Branches     9497     9497           
=======================================
  Hits        40911    40911           
  Misses      18384    18384           
  Partials     2272     2272           
Flag Coverage Δ
Linux 66.39% <ø> (ø)
Windows 66.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zhongnansu
Copy link
Member

zhongnansu commented Feb 20, 2023

I would make sure to sign the last commit @zhongnansu or rebase onto the original commit.

Also, it appears that the OpenSearch JS bump caused a breaking change for downstream dependencies. And we have a revert commit on the way: 32944dd.

So probably best to hold off.

We don't know if there will be feature break unless we run the plugin regression test after this PR merged in

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Feb 21, 2023

This change should not be necessary.

OSD should not be bumping engines.yarn, and now on engines.node, just because a dep needs it or a CVE exists. OSD has a range to provide users the freedom to install whatever works for them.

OSD should only, and only, bump these values when it truly requires something provided by the newer versions.

@AMoo-Miki
Copy link
Collaborator

PS, i messed up the original PR msg but tried to fix it; i think i got it right.

@kavilla
Copy link
Member

kavilla commented Feb 21, 2023

Closing to avoid confusion.

@kavilla kavilla closed this Feb 21, 2023
@zhongnansu
Copy link
Member

zhongnansu commented Feb 21, 2023

@kavilla The reverted commit was re-added to 2.x, with an aliasing solution that doesn't bump js client version. But it will cause the plugin CI failure on 2.x branch. opensearch-project/opensearch-build#3210 (comment)

@zhongnansu
Copy link
Member

The same fix is merged in main. To unblock 2.6 release, I propose we backport to 2.x @seanneumann @joshuarrrr @ananzh
cc: @seraphjiang

github-actions bot and others added 2 commits February 21, 2023 18:16
…rch (#3443)

* upgrade yarn version to 1.22.10 to be compatible with @openearch-project/opensearch

Signed-off-by: Derek Ho <dxho@amazon.com>
(cherry picked from commit dd472fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Copy link
Collaborator

@AMoo-Miki AMoo-Miki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have raised PRs on all plugins that had flaws. This is not a problem that OSD has to or even can solve.

@AMoo-Miki AMoo-Miki removed the v2.7.0 label Feb 22, 2023
@AMoo-Miki AMoo-Miki closed this Feb 22, 2023
@joshuarrrr joshuarrrr deleted the backport/backport-3443-to-2.x branch August 8, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants