Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table Vis] move format table logic to table render and consolidate types #3397

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[Table Vis] move format table logic to table render and consolidate types #3397

merged 1 commit into from
Apr 17, 2023

Commits on Apr 17, 2023

  1. [Table Vis] move format table, consolidate types and add unit tests 

    Currently, table data is formatted by a until function convertToFormattedData
in TableVisComponent. In this PR, we moved the formatting data process
to table_vis_response_handler.ts to combine with other data process
logics. In this way, component render and data handling logics are
completely isolated. This PR also solidate some types.

Issue Resolved:
opensearch-project#3395
opensearch-project#2856

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
    @ananzh
    ananzh committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    e9e9f46 View commit details
    Browse the repository at this point in the history