Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Builder] Add app filter and query persistence without using state container #3202

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8fd8643 from #3100.

…e container (#3100)

* connect without container

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Query and filter persistence working

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Rebase and changelog

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Simplify filter management

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change function name

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit test for function connect storage to query

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* changelog change

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add comments and functional documentation in readme

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more documentation in data persistence readme about vis builder persistence

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* error handling

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add function definition in data plugin api doc

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* document and comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 8fd8643)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 6, 2023 22:41
@abbyhu2000 abbyhu2000 added the autocut Skip the changelog verification check on backports label Jan 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3202 (c0d4d30) into 2.x (1c344b3) will increase coverage by 0.00%.
The diff coverage is 74.19%.

@@           Coverage Diff           @@
##              2.x    #3202   +/-   ##
=======================================
  Coverage   66.65%   66.66%           
=======================================
  Files        3219     3219           
  Lines       61531    61562   +31     
  Branches     9431     9443   +12     
=======================================
+ Hits        41016    41039   +23     
- Misses      18277    18280    +3     
- Partials     2238     2243    +5     
Flag Coverage Δ
Linux 66.60% <74.19%> (+<0.01%) ⬆️
Windows 66.61% <74.19%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/data/public/index.ts 85.71% <ø> (ø)
..._builder/public/application/components/top_nav.tsx 4.34% <0.00%> (-0.20%) ⬇️
.../public/query/state_sync/connect_to_query_state.ts 76.03% <76.66%> (+0.20%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (-4.09%) ⬇️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (-2.64%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 65.77% <0.00%> (+0.88%) ⬆️
...query/state_sync/create_global_query_observable.ts 100.00% <0.00%> (+8.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 7, 2023
@abbyhu2000 abbyhu2000 merged commit 8175ccb into 2.x Jan 7, 2023
@github-actions github-actions bot deleted the backport/backport-3100-to-2.x branch January 7, 2023 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants