[Backport 1.x] Trim trailing slashes before checking no-restricted-path rule #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…true (#3020) `no-restricted-paths` compares source files and import statements, and their membership in restricted zones. However, when `allowSameFolder` is true, it failed to remove a trailing slash before validation which results in a false-positive. Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 8732b1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
kristenTian
previously approved these changes
Dec 9, 2022
|
The tests are failing due to a chrome driver issue the expected version is 106 but this branch has 108 |
AMoo-Miki
previously approved these changes
Dec 22, 2022
Codecov Report
@@ Coverage Diff @@
## 1.x #3052 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 3044 3044
Lines 58696 58696
Branches 8902 8902
=======================================
Hits 39617 39617
Misses 16931 16931
Partials 2148 2148
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Miki <miki@amazon.com>
ananzh
approved these changes
Jan 25, 2023
AMoo-Miki
approved these changes
Jan 25, 2023
joshuarrrr
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 8732b1c from #3020.