[Backport 1.x] Adds @osd/cross-platform (#2681 & #2703) #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds helper functions, @osd/cross-platform, to work around the differences of platforms cherry-pick from 0c9ca96 Signed-off-by: Miki <amoo_miki@yahoo.com>
|
Merge only after #2988 and without squashing |
AMoo-Miki
requested review from
joshuarrrr,
kavilla and
ananzh
and removed request for
joshuarrrr and
kavilla
zhongnansu
approved these changes
Dec 1, 2022
ananzh
approved these changes
Dec 1, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
* [@osd/cross-platform] Adds cross-platform helpers (#2681) cherry-pick from 887093d Signed-off-by: Miki <amoo_miki@yahoo.com> * Adds @osd/cross-platform (#2703) * Adds helper functions, @osd/cross-platform, to work around the differences of platforms cherry-pick from 0c9ca96 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit f9bffcb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
AMoo-Miki
pushed a commit
that referenced
this pull request
Dec 1, 2022
* [@osd/cross-platform] Adds cross-platform helpers (#2681) cherry-pick from 887093d Signed-off-by: Miki <amoo_miki@yahoo.com> * Adds @osd/cross-platform (#2703) * Adds helper functions, @osd/cross-platform, to work around the differences of platforms cherry-pick from 0c9ca96 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit f9bffcb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 887093d from #2681 and 0c9ca96 from #2703