Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSD-2847 bump del version to fix race condition #2873

Merged
merged 3 commits into from
Nov 21, 2022
Merged

OSD-2847 bump del version to fix race condition #2873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7cf652
OSD-2847 bump del version to fix race condition
DanielBelmes Nov 14, 2022
6b5ed75
OSD-2847 Update Changlog.md
DanielBelmes Nov 14, 2022
3a8190a
OSD-2847 Update Changlog.md to be more verbose
DanielBelmes Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- [Table Visualization] Fix first column sort issue ([#2828](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2828))
- Temporary workaround for task-kill exceptions on Windows when it is passed a pid for a process that is already dead ([#2842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2842))
- [Vis Builder] Fix empty workspace animation does not work in firefox ([#2853](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2853))
- Bumped `del` version to fix MacOS race condition ([#2847](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2873))

### 🚞 Infrastructure

Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
"commander": "^3.0.2",
"core-js": "^3.6.5",
"deep-freeze-strict": "^1.1.1",
"del": "^5.1.0",
"del": "^6.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a major version bump of a direct dependency, it should be safe to backport, because the only breaking change in v6 is requiring Node.js 10. Our 1.x branch is already on Node.js 10.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know if other plugins use del

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would that matter - none of them can specify a node engine < 10, right?

"dns-sync": "^0.2.1",
"elastic-apm-node": "^3.7.0",
"elasticsearch": "^16.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-i18n/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@osd/dev-utils": "1.0.0",
"@types/intl-relativeformat": "^2.1.0",
"@types/react-intl": "^2.3.15",
"del": "^5.1.0",
"del": "^6.1.1",
"getopts": "^2.2.5",
"supports-color": "^7.0.0",
"typescript": "4.0.2"
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-interpreter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"babel-loader": "^8.2.3",
"copy-webpack-plugin": "^6.0.2",
"css-loader": "^5.2.7",
"del": "^5.1.0",
"del": "^6.1.1",
"getopts": "^2.2.5",
"pegjs": "0.10.0",
"sass-loader": "^10.2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-monaco/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@osd/dev-utils": "1.0.0",
"babel-loader": "^8.2.3",
"css-loader": "^5.2.7",
"del": "^5.1.0",
"del": "^6.1.1",
"raw-loader": "^4.0.2",
"supports-color": "^7.0.0",
"typescript": "4.0.2",
Expand Down
4 changes: 2 additions & 2 deletions packages/osd-opensearch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"abort-controller": "^3.0.0",
"chalk": "^4.1.0",
"dedent": "^0.7.0",
"del": "^5.1.0",
"del": "^6.1.1",
"execa": "^4.0.2",
"getopts": "^2.2.5",
"glob": "^7.1.7",
Expand All @@ -30,6 +30,6 @@
"devDependencies": {
"@osd/babel-preset": "1.0.0",
"@babel/cli": "^7.16.0",
"del": "^5.1.0"
"del": "^6.1.1"
}
}
2 changes: 1 addition & 1 deletion packages/osd-optimizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"cpy": "^8.0.0",
"core-js": "^3.6.5",
"dedent": "^0.7.0",
"del": "^5.1.0",
"del": "^6.1.1",
"execa": "^4.0.2",
"fibers": "^5.0.3",
"jest-diff": "^27.5.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-plugin-helpers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@osd/cross-platform": "1.0.0",
"@osd/dev-utils": "1.0.0",
"@osd/optimizer": "1.0.0",
"del": "^5.1.0",
"del": "^6.1.1",
"execa": "^4.0.2",
"gulp-zip": "^5.0.2",
"inquirer": "^7.3.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-pm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"cmd-shim": "^2.1.0",
"cpy": "^8.0.0",
"dedent": "^0.7.0",
"del": "^5.1.0",
"del": "^6.1.1",
"execa": "^4.0.2",
"getopts": "^2.2.5",
"glob": "^7.1.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"dependencies": {
"chalk": "^4.1.0",
"dedent": "^0.7.0",
"del": "^5.1.0",
"del": "^6.1.1",
"exit-hook": "^2.2.0",
"getopts": "^2.2.5",
"glob": "^7.1.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/osd-ui-shared-deps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@osd/dev-utils": "1.0.0",
"babel-plugin-transform-react-remove-prop-types": "^0.4.24",
"css-loader": "^5.2.7",
"del": "^5.1.0",
"del": "^6.1.1",
"loader-utils": "^1.2.3",
"val-loader": "^2.1.2",
"webpack": "^4.41.5"
Expand Down
14 changes: 14 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7085,6 +7085,20 @@ del@^6.0.0:
rimraf "^3.0.2"
slash "^3.0.0"

del@^6.1.1:
version "6.1.1"
resolved "https://registry.yarnpkg.com/del/-/del-6.1.1.tgz#3b70314f1ec0aa325c6b14eb36b95786671edb7a"
integrity sha512-ua8BhapfP0JUJKC/zV9yHHDW/rDoDxP4Zhn3AkA6/xT6gY7jYXJiaeyBZznYVujhZZET+UgcbZiQ7sN3WqcImg==
dependencies:
globby "^11.0.1"
graceful-fs "^4.2.4"
is-glob "^4.0.1"
is-path-cwd "^2.2.0"
is-path-inside "^3.0.2"
p-map "^4.0.0"
rimraf "^3.0.2"
slash "^3.0.0"

delaunator@5:
version "5.0.0"
resolved "https://registry.yarnpkg.com/delaunator/-/delaunator-5.0.0.tgz#60f052b28bd91c9b4566850ebf7756efe821d81b"
Expand Down