Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] update sample data for flights and images #255

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 7, 2021

Description

Sample data included kibana and es references so updated that.
Also updated images, some images had some references to kibana
and es, also attempting to run functional tests for plugin gen
failed because it was looking for images references that were
deleted in a previous rename.

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • [ ] New functionality has been documented.
    • [ ] New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

Sample data included kibana and es references so updated that.
Also updated images, some images had some references to kibana
and es, also attempting to run functional tests for plugin gen
failed because it was looking for images references that were
deleted in a previous rename.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla added this to the Beta release milestone Apr 7, 2021
@kavilla kavilla requested review from mihirsoni, boktorbb and ananzh April 7, 2021 19:54
@odfe-release-bot
Copy link

✅   DCO Check Passed 42f19e0

Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mihirsoni mihirsoni merged commit b96ddd9 into opensearch-project:main Apr 8, 2021
@kavilla kavilla deleted the update-sample-data branch April 27, 2021 20:57
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Feb 28, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants