[Backport 2.1] Use a forced CSP-compliant interpreter with Vega visualizations #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Pass `options` to `vega.parse` to enable inclusion of parsed ASTs * Introduce the forced CSP-compliant interpreter that prevents evaluation of unsafe methods * Modified the consumed `leaflet-vega` package to one that honors `options` Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit bebbcca)
ashwin-pc
approved these changes
Sep 15, 2022
joshuarrrr
approved these changes
Sep 16, 2022
|
@joshuarrrr I dont think that can be considered breaking change since relying on insecure behaviour is a security risk that we should not support and that the user should probably figure out a way to get out of |
|
Yeah, that's exactly what I meant, just wanted to point out that it has the potential to break some user workflows, and force them to adapt. But absolutely worth doing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport bebbcca from #2352