[1.0-healthcheck] De-Couple Dashboards linux building process (#795) (#2345) #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* De-Couple Dashboards linux building process When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so. In this PR, we break the building process to allow single linux to build. If run `yarn build-platform --linux-x64` only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could run `yarn build-platform --linux-arm64` and `yarn build-platform darwin-x64`. partially solved: #473 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * support multiple CLI options and fix comments Signed-off-by: AnanZ <ananzh@amazon.com> * fix wording to artifacts Signed-off-by: AnanZ <ananzh@amazon.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-50-84.us-west-2.compute.internal> Co-authored-by: Anan <79961084+ananzh@users.noreply.github.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-50-84.us-west-2.compute.internal>
zhongnansu
approved these changes
Sep 13, 2022
kristenTian
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running yarn build --skip-os-packages it will build 4 tarballs for Dashboards (2x linux, 1x macOS, 1x windows) and takes 10+min to do so.
In this PR, we break the building process to allow single linux to build. If run
yarn build-platform --linux-x64only linux x64 tarball is created. Same for linux arm64 and darwin x64. You could runyarn build-platform --linux-arm64andyarn build-platform darwin-x64.partially solved:
#473
Signed-off-by: Anan Zhuang ananzh@amazon.com
Signed-off-by: AnanZ ananzh@amazon.com
Signed-off-by: AnanZ ananzh@amazon.com
Co-authored-by: Ubuntu ubuntu@ip-172-31-50-84.us-west-2.compute.internal
Co-authored-by: Anan 79961084+ananzh@users.noreply.github.com
Co-authored-by: Ubuntu ubuntu@ip-172-31-50-84.us-west-2.compute.internal
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr