[D&D] Adds visualization type switcher for Wizard #2217
Conversation
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
| @@ -25,6 +46,5 @@ | |||
| } | |||
|
|
|||
| .wizDatasourceSelect { | |||
| max-width: $wizSideNavWidth; | |||
| padding: $euiSize $euiSize 0 $euiSize; | |||
| max-width: calc(#{$wizSideNavWidth} - 1px); | |||
There was a problem hiding this comment.
Should we track this as an enhancement we need in OUI?
There was a problem hiding this comment.
This is a specific with we need for the side panels. I've opened an issue to add resizing and collapsing #2241. That should move this from CSS to JS
| @@ -29,6 +29,7 @@ export const DataSourceSelect = () => { | |||
| const { indexPatterns, loading, error, selected } = useIndexPatterns(); | |||
| const dispatch = useTypedDispatch(); | |||
|
|
|||
| // TODO: Should be a standard EUI component | |||
There was a problem hiding this comment.
NIT: do we have a follow-up up issue? Doesn't have to be committed but so we can reference in the pull request?
There was a problem hiding this comment.
| @@ -5,8 +5,7 @@ | |||
|
|
|||
| import React, { useCallback } from 'react'; | |||
| import { i18n } from '@osd/i18n'; | |||
| import { EuiButtonGroup, EuiFormRow, EuiPanel, EuiSpacer, EuiTitle } from '@elastic/eui'; | |||
| import { FormattedMessage } from 'react-intl'; | |||
| import { EuiButtonGroup, EuiFormRow } from '@elastic/eui'; | |||
There was a problem hiding this comment.
can we explicitly use oui now? both should work right?
There was a problem hiding this comment.
I tried that but Typescript was complaining. So i moved the issue out for later
|
|
|
@kavilla This is a specific with we need for the side panels. I will narrow down the right side panel in the followup PR and I've opened an issue to add resizing and collapsing #2241. That should mitigate this issue for smaller viewports. The smaller right side panel is for the followup Barchart PR and the resize panel PR will come after that. |
* Adds visualization type switcher for Wizard Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Minor fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates options viz options ui Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit c18736a)
* Adds visualization type switcher for Wizard Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Minor fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates options viz options ui Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> (cherry picked from commit c18736a) Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin Pc ashwinpc@amazon.com
Description
Issues Resolved
#954
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr