Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Deprecation] Deprecate the apiVersion: master value and replace with main #1799

Merged
merged 1 commit into from
Jun 29, 2022
Merged

[Deprecation] Deprecate the apiVersion: master value and replace with main #1799

merged 1 commit into from
Jun 29, 2022

Conversation

manasvinibs
Copy link
Member

Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com

Description

As part of the meta issue opensearch-project/OpenSearch#2589 to track the plan and progress of applying inclusive naming across OpenSearch Repositories.

In this change, we are replacing 'apiVersion: master' with 'apiVersion:main'.

Issues Resolved

#1687

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@manasvinibs manasvinibs requested a review from a team as a code owner June 24, 2022 20:44
@manasvinibs manasvinibs self-assigned this Jun 24, 2022
joshuarrrr
joshuarrrr reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on workflows to finish

src/core/server/opensearch/opensearch_config.ts Outdated
* Version of the OpenSearch (6.7, 7.1 or `master`) client will be connecting to.
* Version of the OpenSearch (6.7, 7.1 or `main`) client will be connecting to.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - we should change the version examples while we're editing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@kavilla kavilla linked an issue Jun 24, 2022 that may be closed by this pull request
[Deprecation] Deprecate the apiVersion: master value and replace with ? #1687
Closed
@manasvinibs
[Deprecation] Deprecate the apiVersion: master value and replace with…
251ca4f 
… main

Resolves issue - opensearch-project#1687

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
@manasvinibs manasvinibs requested a review from joshuarrrr June 29, 2022 22:51
@kavilla kavilla merged commit 2e6293e into opensearch-project:main Jun 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
@manasvinibs @github-actions
[Deprecation] Deprecate the apiVersion: master value and replace with…
84c396f 
… main (#1799)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 2e6293e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 29, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 29, 2022
@manasvinibs @github-actions
[Deprecation] Deprecate the apiVersion: master value and replace with…
f15afe9 
… main (#1799)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 2e6293e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jun 29, 2022
Merged
kavilla pushed a commit that referenced this pull request Jun 29, 2022
@opensearch-trigger-bot @manasvinibs
[Deprecation] Deprecate the apiVersion: master value and replace with…
e1380f1 
… main (#1799) (#1831)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 2e6293e)

Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com>
kavilla pushed a commit that referenced this pull request Jul 5, 2022
@opensearch-trigger-bot @manasvinibs
[Deprecation] Deprecate the apiVersion: master value and replace with…
1f407e2 
… main (#1799) (#1830)

Resolves issue - #1687

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit 2e6293e)

Co-authored-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@joshuarrrr joshuarrrr joshuarrrr approved these changes

Assignees

@manasvinibs manasvinibs

Labels
backport 2.x deprecation v2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Deprecation] Deprecate the apiVersion: master value and replace with ?
3 participants
@manasvinibs @joshuarrrr @kavilla