Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] Refactored root directory files #145

Merged
merged 4 commits into from
Mar 13, 2021
Merged

[Rename] Refactored root directory files #145

merged 4 commits into from
Mar 13, 2021

Conversation

mihirsoni
Copy link
Contributor

Issue #, if available: #37

Description of changes: Refactored root directory files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mihirsoni mihirsoni requested review from kavilla and boktorbb March 10, 2021 08:27
boktorbb
boktorbb suggested changes Mar 10, 2021
View reviewed changes
.eslintignore Show resolved Hide resolved
.eslintrc.js Show resolved Hide resolved
.eslintrc.js
Comment on lines -170 to -195
/**
* Files that require Elastic license headers instead of Apache 2.0 header
*/
{
files: ['x-pack/**/*.{js,mjs,ts,tsx}'],
rules: {
'@kbn/eslint/require-license-header': [
'error',
{
license: ELASTIC_LICENSE_HEADER,
},
],
'@kbn/eslint/disallow-license-headers': [
'error',
{
licenses: [
APACHE_2_0_LICENSE_HEADER,
SAFER_LODASH_SET_HEADER,
SAFER_LODASH_SET_LODASH_HEADER,
SAFER_LODASH_SET_DEFINITELYTYPED_HEADER,
],
},
],
},
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these removed?

.eslintrc.js Show resolved Hide resolved
FAQ.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
config/kibana.yml Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
tsconfig.base.json Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
boktorbb
boktorbb approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ananzh
ananzh reviewed Mar 12, 2021
View reviewed changes
.eslintignore Show resolved Hide resolved
ananzh
ananzh reviewed Mar 12, 2021
View reviewed changes
FAQ.md Show resolved Hide resolved
ananzh
ananzh reviewed Mar 12, 2021
View reviewed changes
STYLEGUIDE.md Show resolved Hide resolved
ananzh
ananzh reviewed Mar 12, 2021
View reviewed changes
package.json
@@ -1,9 +1,9 @@
{
"name": "kibana",
"description": "Kibana is a browser based analytics and search dashboard for Elasticsearch. Kibana is a snap to setup and start using. Kibana strives to be easy to get started with, while also being flexible and powerful, just like Elasticsearch.",
"name": "opensearch-dashboards",
Copy link
Member

@ananzh ananzh Mar 12, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 2, why "name":"kibana" --> opensearch-dashboards not opensearchDashboards?
For version name you change to "opensearchDashboards" and in another case kibana.index: ".kibana" -->
opensearchDashboards.index: ".opensearch-dashboards". Seems all names are changes to opensearchDashboards. In line 6 you use opeansearch-dashboards bc it is an app but here it is a name so should be opensearchDashboards?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project name is following hypen -.

kavilla
kavilla requested changes Mar 12, 2021
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
opensearch_dashboards.d.ts Outdated Show resolved Hide resolved
STYLEGUIDE.md Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
README.md
- If you would like to contribute code, please follow our [STYLEGUIDE.md](STYLEGUIDE.md).
- For all other questions, check out the [FAQ.md](FAQ.md) and
[wiki](https://github.com/elastic/kibana/wiki).

## Documentation

Visit [Elastic.co](http://www.elastic.co/guide/en/kibana/current/index.html) for the full Kibana documentation.
Visit [Elastic.co](http://www.elastic.co/guide/en/kibana/current/index.html) for the full OpenSearch Dashboards documentation.

For information about building the documentation, see the README in [elastic/docs](https://github.com/elastic/docs).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elastic

package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@mihirsoni
[Rename] addressed PR comments
bb0093f 
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla
kavilla approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@boktorbb boktorbb merged commit 397790e into opensearch-project:dashboards Mar 13, 2021
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
@mihirsoni @kavilla
[Rename] Refactored root directory files (#145)
3ff3183 
* [Rename] Refactored root directory files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
kavilla pushed a commit that referenced this pull request Mar 20, 2021
@mihirsoni @kavilla
[Rename] Refactored root directory files (#145)
c458db9 
* [Rename] Refactored root directory files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
mihirsoni added a commit that referenced this pull request Mar 20, 2021
@mihirsoni
[Rename] Refactored root directory files (#145)
e4397b7 
* [Rename] Refactored root directory files

* [Rename] addressed review feedbacks

* [Rename] addressed review feedbacks

* [Rename] addressed PR comments

Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
gaobinlong pushed a commit to gaobinlong/OpenSearch-Dashboards that referenced this pull request Sep 20, 2023
@ruanyl
feat: add core workspace module (opensearch-project#145)
d7d712e 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
@ruanyl @SuZhou-Joe
feat: add core workspace module (opensearch-project#145)
e3dcd3c 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 21, 2023
@ruanyl @SuZhou-Joe
feat: add core workspace module (opensearch-project#145)
4e7aa5b 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
@ruanyl
feat: add core workspace module (opensearch-project#145)
8382b59 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
@ruanyl @SuZhou-Joe
feat: add core workspace module (opensearch-project#145)
ba6a4ab 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
kavilla pushed a commit that referenced this pull request Oct 17, 2023
@ruanyl @AMoo-Miki
[Workspace] Feature/workspace service core module (#5092)
9e3e3a7 
* feat: add core workspace module (#145)

The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 1, 2023
@github-actions
[Workspace] Feature/workspace service core module (#5092)
9f656ae 
* feat: add core workspace module (#145)

The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 9e3e3a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
ananzh added a commit that referenced this pull request Dec 14, 2023
@opensearch-trigger-bot @github-actions
@ananzh @AMoo-Miki
[Backport 2.x] [Workspace] Feature/workspace service core module (#5416)
60247dd 
* [Workspace] Feature/workspace service core module (#5092)

* feat: add core workspace module (#145)

The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 9e3e3a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
wanglam pushed a commit to wanglam/OpenSearch-Dashboards that referenced this pull request Feb 22, 2024
@ruanyl @wanglam
feat: add core workspace module (opensearch-project#145)
481f90b 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
@ruanyl @SuZhou-Joe
feat: add core workspace module (opensearch-project#145)
bc555d2 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@boktorbb boktorbb boktorbb approved these changes

@ananzh ananzh ananzh approved these changes

Assignees
No one assigned
Labels
rename
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihirsoni @kavilla @boktorbb @ananzh