-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes interfaced errors across Dashboards #1409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boktorbb
changed the title
Fixes Interfaced Errors across
Fixes Interfaced Errors across Dashboards
Mar 31, 2022
boktorbb
changed the title
Fixes Interfaced Errors across Dashboards
Fixes interfaced errors across Dashboards
Mar 31, 2022
If you could rebase your test should work now. |
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
boktorbb
force-pushed
the
interfaced-errors
branch
from
March 31, 2022 19:39
9f1cce2
to
1c84b2f
Compare
Signed-off-by: Miki <miki@amazon.com>
Fix linting errors
AMoo-Miki
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
ananzh
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kavilla
pushed a commit
that referenced
this pull request
Apr 1, 2022
Origin: #1409 * Reverts re2 back to 1.15.4 from 1.17.4 to fix build issues * Revert to old re2 entry with correct sha hashes Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dependencies:
@types/enzyme
and@types/cheerio
These upgrades expose internal types, like
Cheerio
, to be used in functions@types/cheerio
: patch upgrade from^0.22.10
to^0.22.31
@types/enzyme
: patch upgrade from^3.10.5
to^3.10.7
@types/react
classnames
and removes@types/classnames
classnames
bumped from2.2.6
to2.3.1
@types/classnames
removed since the new version ofclassnames
includes type definitionsenzyme-adapter-react-16
andenzyme-to-json
enzyme-adapter-react-16
from^1.15.2
to^1.15.5
enzyme-to-json
from3.4.4
to^3.5.0
Code:
Transaction
fromapm-rum
. Not sure how the code was working without itscoped_history.ts
andrendering_service.test.ts
scoped_history.ts
, needed to specify the typeLocation<HistoryLocationState>
rendering_service.test.ts
, needed to use|| ''
for a default valuesizeMe.noPlaceholders
todashboard_viewport.test.ts
to allow children to get mounted with Enzymefs.read
so that a unit test can pass inopensearch_config
Issues Resolved
#1393
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr