Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumps @elastic/eui to v34.6.0 and @elastic/charts to v31.1.0 #1370

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Bumps @elastic/eui to v34.6.0 and @elastic/charts to v31.1.0 #1370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/bfetch_explorer/public/components/page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export interface PageProps {

export const Page: React.FC<PageProps> = ({ title = 'Untitled', children }) => {
return (
<EuiPageBody>
<EuiPageBody component="main">
Copy link
Collaborator Author

@AMoo-Miki AMoo-Miki Mar 26, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default element produced used to main but is div now. All these component="main" additions are to make it use main.

<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/embeddable_explorer/public/embeddable_panel_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export function EmbeddablePanelExample({ embeddableServices, searchListContainer
});

return (
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/embeddable_explorer/public/hello_world_embeddable_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ interface Props {

export function HelloWorldEmbeddableExample({ helloWorldEmbeddableFactory }: Props) {
return (
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/embeddable_explorer/public/list_container_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export function ListContainerExample({
};

return (
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/embeddable_explorer/public/todo_embeddable_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class TodoEmbeddableExample extends React.Component<Props, State> {

public render() {
return (
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/routing_example/public/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function RoutingExplorer({
}: Props) {
return (
<EuiPage>
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageContent>
<EuiPageContentHeader>
<EuiText>
Expand Down
2 changes: 1 addition & 1 deletion examples/search_examples/public/components/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ export const SearchExamplesApp = ({
indexPatterns={indexPattern ? [indexPattern] : undefined}
/>
<EuiPage restrictWidth="1000px">
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiTitle size="l">
<h1>
Expand Down
2 changes: 1 addition & 1 deletion examples/state_containers_examples/public/todo/todo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ export const TodoAppPage: React.FC<{
<Router history={props.history}>
<GlobalStateHelpers.Provider value={globalStateContainer}>
<Provider value={container}>
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/state_containers_examples/public/with_data_services/components/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ const App = ({ navigation, data, history, osdUrlStateStorage }: StateDemoAppDeps
showSaveQuery={true}
/>
<EuiPage restrictWidth="1000px">
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiTitle size="l">
<h1>
Expand Down
2 changes: 1 addition & 1 deletion examples/ui_actions_explorer/public/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const ActionsExplorer = ({ uiActionsApi, openModal }: Props) => {
const [confirmationText, setConfirmationText] = useState('');
return (
<EuiPage>
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>Ui Actions Explorer</EuiPageHeader>
<EuiPageContent>
<EuiPageContentBody>
Expand Down
2 changes: 1 addition & 1 deletion examples/ui_actions_explorer/public/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ interface PageProps {

export function Page({ title, children }: PageProps) {
return (
<EuiPageBody data-test-subj="searchTestPage">
<EuiPageBody component="main" data-test-subj="searchTestPage">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
2 changes: 1 addition & 1 deletion examples/url_generators_examples/public/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const Routes: React.FC<{}> = () => {
const query = useQuery();

return (
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageContent>
<EuiPageContentBody>
<Switch>
Expand Down
2 changes: 1 addition & 1 deletion examples/url_generators_explorer/public/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const ActionsExplorer = ({ getLinkGenerator }: Props) => {

return (
<EuiPage>
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>Access links explorer</EuiPageHeader>
<EuiPageContent>
<EuiPageContentBody>
Expand Down
2 changes: 1 addition & 1 deletion examples/url_generators_explorer/public/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ interface PageProps {

export function Page({ title, children }: PageProps) {
return (
<EuiPageBody data-test-subj="searchTestPage">
<EuiPageBody component="main" data-test-subj="searchTestPage">
<EuiPageHeader>
<EuiPageHeaderSection>
<EuiTitle size="l">
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
},
"dependencies": {
"@elastic/datemath": "5.0.3",
"@elastic/eui": "29.3.2",
"@elastic/eui": "34.6.0",
"@elastic/good": "^9.0.1-kibana3",
"@elastic/numeral": "^2.5.0",
"@elastic/request-crypto": "2.0.0",
Expand Down Expand Up @@ -213,7 +213,7 @@
"@babel/register": "^7.16.5",
"@babel/types": "^7.16.0",
"@elastic/apm-rum": "^5.6.1",
"@elastic/charts": "23.2.2",
"@elastic/charts": "31.1.0",
"@elastic/ems-client": "7.10.0",
"@elastic/eslint-config-kibana": "0.15.0",
"@elastic/eslint-plugin-eui": "0.0.2",
Expand Down Expand Up @@ -427,7 +427,7 @@
"redux": "^4.0.5",
"regenerate": "^1.4.0",
"reselect": "^4.0.0",
"resize-observer-polyfill": "^1.5.0",
"resize-observer-polyfill": "^1.5.1",
"sass-lint": "^1.12.1",
"selenium-webdriver": "^4.0.0-alpha.7",
"simple-git": "^3.4.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/osd-plugin-generator/template/public/components/app.tsx.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ import { CoreStart } from '<%= importFromRoot('src/core/public') %>';
<navigation.ui.TopNavMenu appName={ PLUGIN_ID } showSearchBar={true}
useDefaultBehaviors={true} />
<EuiPage restrictWidth="1000px">
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageHeader>
<EuiTitle size="l">
<h1>
Expand Down Expand Up @@ -101,4 +101,4 @@ import { CoreStart } from '<%= importFromRoot('src/core/public') %>';
</I18nProvider>
</Router>
);
};
};
2 changes: 1 addition & 1 deletion packages/osd-ui-framework/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"enzyme-adapter-react-16": "^1.9.1"
},
"devDependencies": {
"@elastic/eui": "29.3.2",
"@elastic/eui": "34.6.0",
"@osd/babel-preset": "1.0.0",
"@osd/optimizer": "1.0.0",
"babel-loader": "^8.2.3",
Expand Down
4 changes: 2 additions & 2 deletions packages/osd-ui-shared-deps/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"osd:watch": "node scripts/build --dev --watch"
},
"dependencies": {
"@elastic/charts": "23.2.2",
"@elastic/eui": "29.3.2",
"@elastic/charts": "31.1.0",
"@elastic/eui": "34.6.0",
"@elastic/numeral": "^2.5.0",
"@osd/i18n": "1.0.0",
"@osd/monaco": "1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion src/core/public/application/ui/app_not_found_screen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { FormattedMessage } from '@osd/i18n/react';

export const AppNotFound = () => (
<EuiPage style={{ minHeight: '100%' }} data-test-subj="appNotFoundPageContent">
<EuiPageBody>
<EuiPageBody component="main">
<EuiPageContent verticalPosition="center" horizontalPosition="center">
<EuiEmptyPrompt
iconType="alert"
Expand Down
Loading