-
Notifications
You must be signed in to change notification settings - Fork 1.1k
TraceDetails: Add Timeline waterfall bars column to SpanDetailTableHierarchy #10642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
TraceDetails: Add Timeline waterfall bars column to SpanDetailTableHierarchy #10642
Conversation
Signed-off-by: Nathan Yang <yanatha@amazon.com>
Signed-off-by: Nathan Yang <yanatha@amazon.com>
Signed-off-by: Nathan Yang <yanatha@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously reviewed.
Tested again and working.
LGTM, thanks for contribution!
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10642 +/- ##
==========================================
+ Coverage 60.18% 60.20% +0.02%
==========================================
Files 4428 4434 +6
Lines 118504 118586 +82
Branches 19456 19476 +20
==========================================
+ Hits 71320 71397 +77
- Misses 42265 42267 +2
- Partials 4919 4922 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Nathan Yang <yanatha@amazon.com>
Description
This PR just cleans up the git commit and rebase history from PR 10610
Add new Timeline waterfall bars column to Tree view table on Trace details page. This is intended to replace the separate Timeline gantt chart as an inline solution to the table for a more cohesive view of the spans.
TimelineWaterfallBar
renders waterfall bar for a span's time rangeSpanDetailTableHierarchy
)useTimelineBarRange
calculates relative bar offset and width based on each span's time range and overall trace time range along with any optional paddingtimelineBarOffsetPercent
andtimelineBarWidthPercent
determine bar positioning and sizedurationMs
,relativeStart
, andrelativeEnd
are passed to bar tooltipuseTimelineBarColor
determines color of bar based on span's service nameTimelineRuler
renders a ruler with evenly spaced "nice" millisecond measurements to visually compare the waterfall barsuseTimelineTicks
calculates optimal tick mark offsets and values for timeline ruler based on overall trace time range (min, max) and desired number of tick marks. Also takes any optional padding into account for scaling.TimelineHeader
renders the Timeline column header, which combines "Timeline" text translation with theTimelineRuler
The span table's "Tree view" has been modified to include new "Timeline" column before the "Duration" column and also hide the "Parent Id" by default to give the "Timeline" column more space.
A new
span_timerange_utils.ts
file has also been added with helper functions for calculating both span and trace time range (durationMs, startTimeMs, endTimeMs).TODO Follow up items
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration