Skip to content

Trace:Details Update column names #10609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2025
Merged

Trace:Details Update column names #10609

merged 3 commits into from
Oct 1, 2025
+49 −1

Conversation

jessrlew
Copy link
Contributor

Description

Use human readable column names for the discover traces table

Issues Resolved

Screenshot

Before:
Screenshot 2025-09-30 at 10 11 46 AM

After:
Screenshot 2025-09-30 at 9 34 31 AM

Testing the changes

Changelog

  • fix: update discover traces column names

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jessrlew
update column names
493c82a 
Signed-off-by: Jessica Lew <jessrlew@amazon.com>
@jessrlew jessrlew requested a review from ps48 as a code owner September 30, 2025 17:13
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.26%. Comparing base (58f770e) to head (55e9608).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10609   +/-   ##
=======================================
  Coverage   60.26%   60.26%           
=======================================
  Files        4386     4386           
  Lines      116884   116894   +10     
  Branches    19056    19057    +1     
=======================================
+ Hits        70441    70450    +9     
  Misses      41578    41578           
- Partials     4865     4866    +1
Flag Coverage Δ
Linux_1 26.66% <ø> (ø)
Linux_2 38.83% <ø> (ø)
Linux_3 38.42% <ø> (ø)
Linux_4 32.67% <100.00%> (+<0.01%) ⬆️
Windows_1 26.67% <ø> (ø)
Windows_2 38.80% <ø> (ø)
Windows_3 38.42% <ø> (-0.01%) ⬇️
Windows_4 32.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jessrlew
fix attributes.service.name column name
55e9608 
Signed-off-by: Jessica Lew <jessrlew@amazon.com>
@jessrlew jessrlew changed the title Discover:Traces Update column names Trace:Details Update column names Sep 30, 2025
@angle943 angle943 added the OSD Changes being merged by the OSD team label Sep 30, 2025
TackAdam
TackAdam approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@TackAdam TackAdam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally against data-prepper schema

Temp fix for column name on specific schema.
Does not convert all data-prepper field names ie (serviceName and durationInNanos) but this is not blocking as field-mapping fix is required to cover all schemes.

@LDrago27 LDrago27 merged commit 60602fc into opensearch-project:main Oct 1, 2025
133 of 137 checks passed
yanatha99 pushed a commit to yanatha99/OpenSearch-Dashboards that referenced this pull request Oct 2, 2025
@jessrlew @opensearch-changeset-bot
Trace:Details Update column names (opensearch-project#10609)
a474901 
* update column names

Signed-off-by: Jessica Lew <jessrlew@amazon.com>

* Changeset file for PR opensearch-project#10609 created/updated

* fix attributes.service.name column name

Signed-off-by: Jessica Lew <jessrlew@amazon.com>

---------

Signed-off-by: Jessica Lew <jessrlew@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Nathan Yang <yanatha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LDrago27 LDrago27 LDrago27 approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

@angle943 angle943 Awaiting requested review from angle943 angle943 is a code owner

@Maosaic Maosaic Awaiting requested review from Maosaic Maosaic is a code owner

@wanglam wanglam Awaiting requested review from wanglam wanglam is a code owner

@d-buckner d-buckner Awaiting requested review from d-buckner d-buckner is a code owner

@raintygao raintygao Awaiting requested review from raintygao raintygao is a code owner

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

+1 more reviewer

@TackAdam TackAdam TackAdam approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
OSD Changes being merged by the OSD team repeat-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jessrlew @LDrago27 @abbyhu2000 @TackAdam @angle943