Skip to content

Conversation

abbyhu2000
Copy link
Member

@abbyhu2000 abbyhu2000 commented Sep 27, 2025

Description

auto turn on the following config when explore is turned on

data.savedQueriesNewUI.enabled: true
opensearchDashboards.branding:
  useExpandedHeader: false
uiSettings:
  overrides:
    "theme:version": "v9"
    "home:useNewHomePage": true
    "query:enhancements:enabled": true

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: explore experience will auto turn on few other flags

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.25%. Comparing base (dfc3f48) to head (0ec7d71).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10588      +/-   ##
==========================================
- Coverage   60.25%   60.25%   -0.01%     
==========================================
  Files        4385     4385              
  Lines      116753   116753              
  Branches    19010    19010              
==========================================
- Hits        70346    70345       -1     
  Misses      41568    41568              
- Partials     4839     4840       +1     
Flag Coverage Δ
Linux_1 26.66% <ø> (ø)
Linux_2 38.83% <ø> (ø)
Linux_3 38.42% <ø> (-0.01%) ⬇️
Linux_4 32.60% <ø> (ø)
Windows_1 26.67% <ø> (ø)
Windows_2 38.80% <ø> (ø)
Windows_3 38.42% <ø> (-0.01%) ⬇️
Windows_4 32.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
@abbyhu2000 abbyhu2000 added the OSD Changes being merged by the OSD team label Sep 30, 2025
enabled: true,
},
schema: configSchema,
deprecations: ({ rename, unused }) => [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abbyhu2000 Are deprecations the right way to do it. it seems from prior usage as a way to just annotate settings that are unused.

deprecations: ({ unused }) => [unused('defaultLanguage')],

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea it was a bit of the customized usage of deprecations. But after investigation, i realized to auto-enable these settings when explore flag is on is to either use deprecations or to modify the core system code during plugin discovery phase(src/core/server/plugins/discovery/plugins_discovery.ts). I feel like changing the core plugin discovery code might be against the architecture, thus i utilize the deprecations as a hack. @ashwin-pc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets just call out this hack and mark it as not a pattern we want to follow in the comments. Given our start to build 4.0, this is just a stop gap solution with minimal changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this needs to block this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge this and add the comment in the following PR.

@abbyhu2000 abbyhu2000 merged commit 02e0b49 into opensearch-project:main Sep 30, 2025
234 of 240 checks passed
@ps48 ps48 added the v3.3.0 Issues targeting release v3.3.0 label Oct 2, 2025
@ps48
Copy link
Member

ps48 commented Oct 2, 2025

linked with #10490

yanatha99 pushed a commit to yanatha99/OpenSearch-Dashboards that referenced this pull request Oct 2, 2025
Signed-off-by: Nathan Yang <yanatha@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor OSD Changes being merged by the OSD team v3.3.0 Issues targeting release v3.3.0
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

7 participants