-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Explore Vis] Date String Normalization #10574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lunalzm
wants to merge
2
commits into
opensearch-project:main
Choose a base branch
from
lunalzm:normalize-date-strings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+111
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to lunalzm/OpenSearch-Dashboards
that referenced
this pull request
Sep 26, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10574 +/- ##
==========================================
- Coverage 60.20% 60.20% -0.01%
==========================================
Files 4302 4302
Lines 115109 115111 +2
Branches 18695 18696 +1
==========================================
- Hits 69299 69298 -1
- Misses 41057 41058 +1
- Partials 4753 4755 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SuZhou-Joe
reviewed
Sep 26, 2025
src/plugins/explore/public/components/visualizations/utils/normalize_result_rows.ts
Outdated
Show resolved
Hide resolved
97041b1
to
e93d7fa
Compare
ruanyl
previously approved these changes
Sep 28, 2025
Signed-off-by: Luna Liu <lunalzm@amazon.com>
e93d7fa
to
d7eba71
Compare
ruanyl
previously approved these changes
Sep 29, 2025
Signed-off-by: Luna Liu <lunalzm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, time fields in the result set may appear as plain strings (e.g., "2025-09-24 14:50:00") without timezone information.
As a result, visualizations always display them in UTC, and the times do not adjust according to the system timezone settings (e.g., UTC+8).
Screenshot
Before
After
Changelog
Check List
yarn test:jest
yarn test:jest_integration