-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WIP] Discover: Trace #10214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: query_explore
Are you sure you want to change the base?
[WIP] Discover: Trace #10214
Conversation
Signed-off-by: Adam Tackett <tackadam@amazon.com>
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 10214.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## query_explore #10214 +/- ##
================================================
Coverage ? 50.87%
================================================
Files ? 3815
Lines ? 96743
Branches ? 15151
================================================
Hits ? 49215
Misses ? 44693
Partials ? 2835
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
'durationInNanos', | ||
]) | ||
); | ||
}, [dispatch]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we do this in the preloaded state of redux when it mounts for traces? I want to decrease the use of useEffects as much as possible in the codebase, and they are typically required when we need the react app to be in sync with some outside sync (like an api call), but this does not seem to be the case here
dataset.formatField = originalFormatField; | ||
}; | ||
}, [dataset]); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this code live in the dataset object?
flavor = ExploreFlavor.Traces; | ||
} else if (path.includes(`/${ExploreFlavor.Metrics}`)) { | ||
flavor = ExploreFlavor.Metrics; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets throw an error if its not one of them
Signed-off-by: Adam Tackett <tackadam@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's ideal to do context switch at this container component level, I will propose each page(logs/traces) should build their own container.
Description
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration