Skip to content

[WIP] Discover: Trace #10214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: query_explore
Choose a base branch
from

Conversation

TackAdam
Copy link
Contributor

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 10214.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 2.54777% with 153 lines in your changes missing coverage. Please review.

Please upload report for BASE (query_explore@b497761). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...e/public/components/chart/traces_metrics_panel.tsx 0.85% 116 Missing ⚠️
...s/explore/public/components/chart/traces_chart.tsx 0.00% 19 Missing ⚠️
...e/public/components/chart/traces_error_detector.ts 5.88% 16 Missing ⚠️
.../bottom_right_container/bottom_right_container.tsx 50.00% 0 Missing and 1 partial ⚠️
...rc/plugins/explore/public/components/tabs/tabs.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             query_explore   #10214   +/-   ##
================================================
  Coverage                 ?   50.87%           
================================================
  Files                    ?     3815           
  Lines                    ?    96743           
  Branches                 ?    15151           
================================================
  Hits                     ?    49215           
  Misses                   ?    44693           
  Partials                 ?     2835           
Flag Coverage Δ
Linux_1 27.68% <ø> (?)
Linux_2 41.25% <ø> (?)
Linux_4 31.63% <2.54%> (?)
Windows_1 27.70% <ø> (?)
Windows_2 41.23% <ø> (?)
Windows_4 31.63% <2.54%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

'durationInNanos',
])
);
}, [dispatch]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do this in the preloaded state of redux when it mounts for traces? I want to decrease the use of useEffects as much as possible in the codebase, and they are typically required when we need the react app to be in sync with some outside sync (like an api call), but this does not seem to be the case here

dataset.formatField = originalFormatField;
};
}, [dataset]);
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this code live in the dataset object?

flavor = ExploreFlavor.Traces;
} else if (path.includes(`/${ExploreFlavor.Metrics}`)) {
flavor = ExploreFlavor.Metrics;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets throw an error if its not one of them

TackAdam and others added 2 commits July 21, 2025 11:26
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's ideal to do context switch at this container component level, I will propose each page(logs/traces) should build their own container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants