-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[WIP] Add dataset select and service to explore #10081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: query_explore
Are you sure you want to change the base?
[WIP] Add dataset select and service to explore #10081
Conversation
The dataset select component alongside the data view service. The original plan of dataset service came with conflicts with the existing dataset and the dataset interface in the query does not nicely confirm to index pattern. So data view acts as a direct fork of index pattern to avoid backwards compatibility issues for existing index patterns and to not break the query enhancements logic. This is the initial foundation. Will clean up unused and make it more unique to datasets Signed-off-by: Kawika Avilla <kavilla414@gmail.com> fix type issues Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Changeset file for PR opensearch-project#10014 created/updated Update plugin.ts fix tests Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Add Shenoy Pratik (@ps48) as a maintainer Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#9976 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…search-project#10020) * Increase timeout waiting for the exiting of an optimizer worker Notice it was showing the failed to timeout again so bumping it up like: opensearch-project#3193 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Changeset file for PR opensearch-project#10020 created/updated --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
2 similar comments
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
|
|
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Description
TODO
dataset
#10014
The dataset select component alongside the data view service.
NOTE: This is the initial foundational work. Will clean up unused and make it more unique to datasets but people can review this PR under the assumption this is similar to index patterns
The original PR: #9980 had conflicts with namespacing that typescript was getting thrown off. It had conflicts with the existing dataset and the dataset interface in the query does not nicely confirm to index pattern. The next logical namespace for me was data view which is a view of the data.
So data view acts as a direct fork of index pattern to avoid backwards compatibility issues for existing index patterns and to not break the query enhancements logic.
This also includes the change to run story book on a multiple ports. Since the storybook for this plugin is not the explore plugin I wanted the ability to run the storybook for each plugin not just one at a time.
Issues Resolved
#9791
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration