Skip to content

[WIP] Add dataset select and service to explore #10081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: query_explore
Choose a base branch
from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 9, 2025

Description

Screenshot 2025-07-08 at 5 53 51 PM Screenshot 2025-07-09 at 4 56 19 PM

TODO

  • Update the buttons to open the explore view where users can select data without creating an index pattern
  • some minor UX touchups
  • remove the label dataset
  • recent datasets

#10014

The dataset select component alongside the data view service.

NOTE: This is the initial foundational work. Will clean up unused and make it more unique to datasets but people can review this PR under the assumption this is similar to index patterns

The original PR: #9980 had conflicts with namespacing that typescript was getting thrown off. It had conflicts with the existing dataset and the dataset interface in the query does not nicely confirm to index pattern. The next logical namespace for me was data view which is a view of the data.

So data view acts as a direct fork of index pattern to avoid backwards compatibility issues for existing index patterns and to not break the query enhancements logic.

This also includes the change to run story book on a multiple ports. Since the storybook for this plugin is not the explore plugin I wanted the ability to run the storybook for each plugin not just one at a time.

Issues Resolved

#9791

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

kavilla and others added 6 commits July 1, 2025 08:49
The dataset select component alongside the data view service.

The original plan of dataset service came with conflicts with the existing dataset and
the dataset interface in the query does not nicely confirm to index pattern. So data view
acts as a direct fork of index pattern to avoid backwards compatibility issues for existing
index patterns and to not break the query enhancements logic.

This is the initial foundation. Will clean up unused and make it more unique to datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

fix type issues

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Changeset file for PR opensearch-project#10014 created/updated

Update plugin.ts

fix tests

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Add Shenoy Pratik (@ps48) as a maintainer

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR opensearch-project#9976 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…search-project#10020)

* Increase timeout waiting for the exiting of an optimizer worker

Notice it was showing the failed to timeout again so bumping it up like:
opensearch-project#3193

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR opensearch-project#10020 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

github-actions bot commented Jul 9, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

2 similar comments
Copy link
Contributor

github-actions bot commented Jul 9, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Jul 9, 2025

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@kavilla
Copy link
Member Author

kavilla commented Jul 9, 2025

  • label for select component should be Data temporarily
  • in the future, the temp dataset created in the saved search should be translated to using the virtual all dataset object. if i find if that not to be compat with specific data sources then we should bring it up
  • single button dont show manage and create
  • re-add recent datasets
  • for details use the description component
  • selector text to be smaller
  • change timefield in details not be selector
  • Manage for the dataset details iif index pattern
  • datasetdetails data definition on click takes you to the appropriate view like data source or index pattern

@kamingleung
Copy link

  • In the three-dot menu, consider using description list component for displaying the meta information. Remove the borders
  • Consider removing the icons and show a check on the selected item: see single selectable
  • In the three-dot menu, If the timefield is read-only, show as key-value text. Avoid using disabled dropdown.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@kamingleung
Copy link

kamingleung commented Jul 14, 2025

  • The dropdown width should be fixed, it shouldn't resize based on the text width. We should truncate the text if it's too long to fit the dropdown:
image
  • Hide the "Default" badge if the dataset is not a default dataset:
image
  • When user is viewing a default dataset, the badge should not be clickable or focusable, it's read-only:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants