Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Rename sample data index with prefix sample_* #2676

Open
mihirsoni opened this issue Oct 26, 2022 · 3 comments
Open

[Enhancement] Rename sample data index with prefix sample_* #2676

mihirsoni opened this issue Oct 26, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@mihirsoni
Copy link
Contributor

mihirsoni commented Oct 26, 2022

Is your feature request related to a problem? Please describe.
Sample data index are named with opensearch_dashboards_sample_data_* this works great but since there are lot of chances that customer might have actual logs named index opensearch_* or any other real logs. This could conflict since one can have template on opensearch_* open-search dashboards sample index to get applied

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
Proposing to rename the sample data index name to prefix with sample and remove the opensearch_dashboards prefix to remove any accidential collision that could happen.

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

@mihirsoni mihirsoni added the enhancement New feature or request label Oct 26, 2022
@joshuarrrr
Copy link
Member

Do we think there's benefit in any further attempts to prevent collisions?

  • sample_data_*
  • vs _sample_data_*
  • vs __sample_data__*

@mihirsoni
Copy link
Contributor Author

@joshuarrrr we can't start index name prefixed with _ and is not allowed characters in OpenSearch. _ is reserved for the internal APIs like _cat/indices, _cluster/status.

@joshuarrrr
Copy link
Member

Are there other allowed characters we can use to further minimize collision risk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants