Change color fn used to calculate icon colors for search typeahead su…

…ggestions (#4884) (#4886)

Icons don't need to be as high contrast as text, so the 3:1 threshold of `makeGraphicContrastColor` is more appropriate


(cherry picked from commit b24f33a)

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

src/plugins/data/public/ui/typeahead/_suggestion.scss

@@ -102,7 +102,7 @@ $osdTypeaheadTypes: (
     &.osdSuggestionItem--#{$name} {
       .osdSuggestionItem__type {
         background-color: tintOrShade($color, 90%, 50%);
-        color: makeHighContrastColor($color, tintOrShade($color, 90%, 50%));
+        color: makeGraphicContrastColor($color, tintOrShade($color, 90%, 50%));
       }
     }
   }