Github comment feedback

Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
opensearch-project · Sep 7, 2022 · e8b4899 · e8b4899
1 parent 240cc1e
commit e8b4899
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/src/plugins/wizard/public/application/_variables.scss b/src/plugins/wizard/public/application/_variables.scss
@@ -7,4 +7,3 @@
 
 $osdHeaderOffset: $euiHeaderHeightCompensation;
 $wizLeftNavWidth: 462px;
-$wizRightNavWidth: 320px;
diff --git a/src/plugins/wizard/public/application/components/right_nav.tsx b/src/plugins/wizard/public/application/components/right_nav.tsx
@@ -79,7 +79,7 @@ export const RightNav = () => {
           <p>
             <FormattedMessage
               id="wizard.rightNav.changeVisType.modalDescription"
-              defaultMessage="Currently, changing the visualization type clears the existing selection of fields. Are you sure you want to change the visualization type?"
+              defaultMessage="Changing the visualization type will reset all field selections. Are you sure you want to continue?"
             />
           </p>
         </EuiConfirmModal>

diff --git a/src/plugins/wizard/public/visualizations/common/expression_helpers.ts b/src/plugins/wizard/public/visualizations/common/expression_helpers.ts
@@ -16,6 +16,7 @@ export const getAggExpressionFunctions = async (visualization: VisualizationStat
 
   const indexPatternsService = getIndexPatterns();
   const indexPattern = await indexPatternsService.get(indexId);
+  // aggConfigParams is the serealizeable aggConfigs that need to be reconstructed here using the agg servce
   const aggConfigs = getAggService().createAggConfigs(indexPattern, cloneDeep(aggConfigParams));
 
   const opensearchDashboards = buildExpressionFunction<ExpressionFunctionOpenSearchDashboards>(

diff --git a/src/plugins/wizard/public/visualizations/vislib/histogram/histogram_vis_type.ts b/src/plugins/wizard/public/visualizations/vislib/histogram/histogram_vis_type.ts
@@ -34,7 +34,7 @@ export const createHistogramConfig = (): VisualizationTypeOptions<HistogramOptio
             }),
             min: 1,
             max: 3,
-            aggFilter: ['!geo_centroid', '!geo_bounds'], // '!geo_centroid', '!geo_bounds'
+            aggFilter: ['!geo_centroid', '!geo_bounds'],
             defaults: { aggTypes: ['median'] },
           },
           {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -7,4 +7,3 @@

		$osdHeaderOffset: $euiHeaderHeightCompensation;
		$wizLeftNavWidth: 462px;
		$wizRightNavWidth: 320px;
-Original file line number
+Diff line change
@@ Expand Up @@
                 }),
                 min: 1,
                 max: 3,
-                aggFilter: ['!geo_centroid', '!geo_bounds'], // '!geo_centroid', '!geo_bounds'
+                aggFilter: ['!geo_centroid', '!geo_bounds'],
                 defaults: { aggTypes: ['median'] },
               },
               {
@@ Expand Down @@