don't relay on text to drop home

Signed-off-by: Hailong Cui <ihailong@amazon.com>

src/core/public/chrome/ui/header/header.tsx

@@ -204,14 +204,14 @@ export function Header({
     />
   );
 
-  const renderBreadcrumbs = (renderFullLength?: boolean, hideFirstHome?: boolean) => (
+  const renderBreadcrumbs = (renderFullLength?: boolean, dropHomeFromBreadcrumb?: boolean) => (
     <HeaderBreadcrumbs
       appTitle$={observables.appTitle$}
       breadcrumbs$={observables.breadcrumbs$}
       breadcrumbsEnricher$={observables.breadcrumbsEnricher$}
       useUpdatedHeader={useUpdatedHeader}
       renderFullLength={renderFullLength}
-      hideFirstHome={hideFirstHome}
+      dropHomeFromBreadcrumb={dropHomeFromBreadcrumb}
     />
   );
 

src/core/public/chrome/ui/header/header_breadcrumbs.test.tsx

@@ -31,8 +31,8 @@
 import { mount } from 'enzyme';
 import React from 'react';
 import { act } from 'react-dom/test-utils';
-import { BehaviorSubject } from 'rxjs';
-import { ChromeBreadcrumb } from '../../chrome_service';
+import { BehaviorSubject, Observable } from 'rxjs';
+import { ChromeBreadcrumb, ChromeBreadcrumbEnricher } from '../../chrome_service';
 import { HeaderBreadcrumbs } from './header_breadcrumbs';
 
 describe('HeaderBreadcrumbs', () => {
@@ -111,7 +111,7 @@ describe('HeaderBreadcrumbs', () => {
   it('remove heading home when workspace is enabled', () => {
     const breadcrumbs$ = new BehaviorSubject([{ text: 'First' }]);
     const breadcrumbsEnricher$ = new BehaviorSubject((crumbs: ChromeBreadcrumb[]) => [
-      { text: 'Home' },
+      { text: 'Home', home: true },
       { text: 'Analytics' },
       ...crumbs,
     ]);
@@ -120,12 +120,22 @@ describe('HeaderBreadcrumbs', () => {
         appTitle$={new BehaviorSubject('')}
         breadcrumbs$={breadcrumbs$}
         breadcrumbsEnricher$={breadcrumbsEnricher$}
-        hideFirstHome={true}
+        dropHomeFromBreadcrumb={true}
       />
     );
     const breadcrumbs = wrapper.find('.euiBreadcrumbWrapper');
     expect(breadcrumbs).toHaveLength(2);
     expect(breadcrumbs.at(0).text()).toBe('Analytics');
     expect(breadcrumbs.at(1).text()).toBe('First');
+
+    // if no home property, we don't drop by text
+    act(() => {
+      breadcrumbsEnricher$.next((items) => items);
+      breadcrumbs$.next([{ text: 'Home' }, { text: 'Second' }]);
+    });
+    wrapper.update();
+    expect(breadcrumbs).toHaveLength(2);
+    expect(breadcrumbs.at(0).text()).toBe('Home');
+    expect(breadcrumbs.at(1).text()).toBe('Second');
   });
 });

src/core/public/chrome/ui/header/header_breadcrumbs.tsx

@@ -41,7 +41,7 @@ interface Props {
   breadcrumbsEnricher$: Observable<ChromeBreadcrumbEnricher | undefined>;
   useUpdatedHeader?: boolean;
   renderFullLength?: boolean;
-  hideFirstHome?: boolean;
+  dropHomeFromBreadcrumb?: boolean;
 }
 
 export function HeaderBreadcrumbs({
@@ -50,7 +50,7 @@ export function HeaderBreadcrumbs({
   breadcrumbsEnricher$,
   useUpdatedHeader,
   renderFullLength,
-  hideFirstHome,
+  dropHomeFromBreadcrumb,
 }: Props) {
   const appTitle = useObservable(appTitle$, 'OpenSearch Dashboards');
   const breadcrumbs = useObservable(breadcrumbs$, []);
@@ -75,7 +75,7 @@ export function HeaderBreadcrumbs({
     crumbs = breadcrumbEnricher(crumbs);
   }
 
-  if (hideFirstHome && crumbs[0].text === 'Home') {
+  if (dropHomeFromBreadcrumb && Object.hasOwn(crumbs[0], 'home')) {
     crumbs = crumbs.slice(1);
   }
 

src/plugins/workspace/public/utils.ts

@@ -385,8 +385,9 @@ export function prependWorkspaceToBreadcrumbs(
     return;
   }
 
-  const homeBreadcrumb: ChromeBreadcrumb = {
+  const homeBreadcrumb: ChromeBreadcrumb & { home: boolean } = {
     text: 'Home',
+    home: true,
     onClick: () => {
       core.application.navigateToApp('home');
     },