address comments

Signed-off-by: Su <szhongna@amazon.com>
opensearch-project · Apr 5, 2023 · 953bc10 · 953bc10
1 parent 1ca3663
commit 953bc10
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 16 deletions.
diff --git a/...c/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx b/...c/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
@@ -120,7 +120,7 @@ export class CreateDataSourceForm extends React.Component<
     });
   };
 
-  onChangeAuthType = (e: { target: { value: any } }) => {
+  onChangeAuthType = (e: React.ChangeEvent<HTMLSelectElement>) => {
     this.setState({ auth: { ...this.state.auth, type: e.target.value as AuthType } });
   };
 

diff --git a/...nt/public/components/edit_data_source/components/edit_form/edit_data_source_form.test.tsx b/...nt/public/components/edit_data_source/components/edit_form/edit_data_source_form.test.tsx
@@ -290,7 +290,7 @@ describe('Datasource Management: Edit Datasource Form', () => {
     });
 
     /* Save Changes */
-    test('should update the form with NoAUth on click save chan ges', async () => {
+    test('should update the form with NoAuth on click save changes', async () => {
       await new Promise((resolve) =>
         setTimeout(() => {
           updateInputFieldAndBlur(component, descriptionFieldIdentifier, '');

diff --git a/...agement/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx b/...agement/public/components/edit_data_source/components/edit_form/edit_data_source_form.tsx
@@ -162,7 +162,7 @@ export class EditDataSourceForm extends React.Component<EditDataSourceProps, Edi
     });
   };
 
-  onChangeAuthType = (e: { target: { value: any } }) => {
+  onChangeAuthType = (e: React.ChangeEvent<HTMLSelectElement>) => {
     this.setState({ auth: { ...this.state.auth, type: e.target.value as AuthType } }, () => {
       this.onChangeFormValues();
     });
@@ -738,13 +738,6 @@ export class EditDataSourceForm extends React.Component<EditDataSourceProps, Edi
             defaultMessage: 'Credential',
           })}
         >
-          {/* <EuiRadioGroup
-            options={credentialSourceOptions}
-            idSelected={this.state.auth.type}
-            onChange={(id) => this.onChangeAuthType(id)}
-            name="Credential"
-            data-test-subj="editDataSourceSelectAuthType"
-          /> */}
           <EuiSelect
             options={credentialSourceOptions}
             value={this.state.auth.type}

diff --git a/src/plugins/data_source_management/public/types.ts b/src/plugins/data_source_management/public/types.ts
@@ -56,12 +56,6 @@ export enum AuthType {
   SigV4 = 'sigv4',
 }
 
-// export const credentialSourceOptions = [
-//   { id: AuthType.NoAuth, label: 'No authentication' },
-//   { id: AuthType.UsernamePasswordType, label: 'Username & Password' },
-//   { id: AuthType.SigV4, label: 'AWS SigV4' },
-// ];
-
 export const credentialSourceOptions = [
   { value: AuthType.NoAuth, text: 'No authentication' },
   { value: AuthType.UsernamePasswordType, text: 'Username & Password' },