Add descriptions for translators (#29089)

opensearch-project · Jan 22, 2019 · 0d6d59e · 0d6d59e
1 parent b0e08dc
commit 0d6d59e
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js b/src/legacy/core_plugins/kibana/public/dashboard/listing/dashboard_listing.js
@@ -394,6 +394,7 @@ class DashboardListingUi extends React.Component {
             aria-label={intl.formatMessage({
               id: 'kbn.dashboard.listing.searchBar.searchFieldAriaLabel',
               defaultMessage: 'Filter dashboards',
+              description: '"Filter" is used as a verb here, similar to "search through dashboards".',
             })}
             placeholder={intl.formatMessage({
               id: 'kbn.dashboard.listing.searchBar.searchFieldPlaceholder',

diff --git a/src/legacy/core_plugins/kibana/ui_setting_defaults.js b/src/legacy/core_plugins/kibana/ui_setting_defaults.js
@@ -845,6 +845,7 @@ export function getUiSettingDefaults() {
     'filterEditor:suggestValues': {
       name: i18n.translate('kbn.advancedSettings.suggestFilterValuesTitle', {
         defaultMessage: 'Filter editor suggest values',
+        description: '"Filter editor" refers to the UI you create filters in.',
       }),
       value: true,
       description: i18n.translate('kbn.advancedSettings.suggestFilterValuesText', {

diff --git a/src/ui/public/agg_types/buckets/filters.js b/src/ui/public/agg_types/buckets/filters.js
@@ -32,6 +32,7 @@ export const filtersBucketAgg = new BucketAggType({
   name: 'filters',
   title: i18n.translate('common.ui.aggTypes.buckets.filtersTitle', {
     defaultMessage: 'Filters',
+    description: 'The name of an aggregation, that allows to specify multiple individual filters to group data by.'
   }),
   createFilter: createFilterFilters,
   customLabels: false,

diff --git a/src/ui/public/agg_types/controls/filters.html b/src/ui/public/agg_types/controls/filters.html
@@ -50,6 +50,7 @@
         i18n-id="common.ui.aggTypes.filters.definiteFilterLabel"
         i18n-default-message="Filter {index} label"
         i18n-values="{ index: $index + 1 }"
+        i18n-description="'Filter {index}' represents the name of the filter as a noun, similar to 'label for filter 1'."
       ></label>
       <input
         id="visEditorFilterLabelInput{{agg.id}}"