Update RESPONSIBILITIES.md #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add code merge responsibility. Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
sandeshkr419
requested review from
CEHENKLE,
dblock,
mch2,
peternied and
saratvemulapalli
as code owners
dblock
requested changes
Apr 6, 2024
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
|
Thanks @dblock for the review & suggestions. I have incorporated them in my last commit. |
dblock
previously approved these changes
Apr 9, 2024
andrross
reviewed
Apr 9, 2024
Co-authored-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
Signed-off-by: Sandesh Kumar <sandeshkr419@gmail.com>
|
Thanks @andrross for the review. Iterated the guidelines with your comments. Let me know if the revised guidelines are more meaningful now. |
andrross
approved these changes
Apr 10, 2024
dblock
approved these changes
Apr 10, 2024
dblock
approved these changes
Apr 16, 2024
peternied
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add code merge responsibilities for maintainers.
Description
opensearch-project/OpenSearch#851
Pulling in code merge best practices from opensearch-project/security#2134
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.