Skip to content

Conversation

@Amirsaeed7
Copy link
Contributor

In this PR i added events of the first four month from the Bahesab Calendar
here are the questions i wanted to ask:

30 Farvardin --> " روز آزمایشگاهیان" and 'روز علوم آزمایشگاهی، زاد‌روز حکیم سید اسماعیل جرجانی' are these both events needed?

In the bahesab calendar the date of this event (شهادت امام محمد تقی علیه السلام) is "29 ذی القعده" but in the previous code it is mentioned as 30th of the month but based on my research it is on the 30th

is both this events needed "شلیک به پرواز 655 ایران ایر توسط ناو وینسنس [ 1367 خورشیدی ]" and "حمله ناوگان آمریکا به هواپیمای مسافربری جمهوری اسلامی ایران"

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (6c1ca8e) to head (43a0c7a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #39   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files           7        7           
  Lines         109      109           
  Branches       25       25           
=======================================
  Hits          106      106           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sepandhaghighi
Copy link
Member

In this PR i added events of the first four month from the Bahesab Calendar here are the questions i wanted to ask:

30 Farvardin --> " روز آزمایشگاهیان" and 'روز علوم آزمایشگاهی، زاد‌روز حکیم سید اسماعیل جرجانی' are these both events needed?

In the bahesab calendar the date of this event (شهادت امام محمد تقی علیه السلام) is "29 ذی القعده" but in the previous code it is mentioned as 30th of the month but based on my research it is on the 30th

is both this events needed "شلیک به پرواز 655 ایران ایر توسط ناو وینسنس [ 1367 خورشیدی ]" and "حمله ناوگان آمریکا به هواپیمای مسافربری جمهوری اسلامی ایران"

  1. Only keep 'روز علوم آزمایشگاهی، زاد‌روز حکیم سید اسماعیل جرجانی'

  2. 30th is correct

  3. Only keep "شلیک به پرواز 655 ایران ایر توسط ناو وینسنس [ 1367 خورشیدی ]"

{'description': 'روز بزرگداشت صائب تبریزی', 'is_holiday': False},
{'description': 'روز دیپلماسی فرهنگی و تعامل با جهان', 'is_holiday': False},
{'description': 'آزادسازی شهر مهران', 'is_holiday': False},
{'description': 'بزرگداشت صائب تبریزی', 'is_holiday': False}],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplication

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fixed.

@sadrasabouri
Copy link
Member

@sepandhaghighi @Amirsaeed7 I can't open [Bahesab[(https://www.bahesab.ir/) probably due the Iran's connection situations. What should we do?

@Amirsaeed7
Copy link
Contributor Author

@sepandhaghighi @Amirsaeed7 I can't open [Bahesab[(https://www.bahesab.ir/) probably due the Iran's connection situations. What should we do?

Based on your past reviews i think what you need is the list of events for each month for both 1404 and 1405 .
Is it possible to get you this info manually? by sharing images or sth?

@sadrasabouri
Copy link
Member

@sepandhaghighi @Amirsaeed7 I can't open [Bahesab[(https://www.bahesab.ir/) probably due the Iran's connection situations. What should we do?

Based on your past reviews i think what you need is the list of events for each month for both 1404 and 1405 . Is it possible to get you this info manually? by sharing images or sth?

Yeah, download the HTML file of the month(s) so I can open them all here.

@Amirsaeed7
Copy link
Contributor Author

@sepandhaghighi @Amirsaeed7 I can't open [Bahesab[(https://www.bahesab.ir/) probably due the Iran's connection situations. What should we do?

Based on your past reviews i think what you need is the list of events for each month for both 1404 and 1405 . Is it possible to get you this info manually? by sharing images or sth?

Yeah, download the HTML file of the month(s) so I can open them all here.

In this folder i provided 8 text files containing the html data of the list of events of Bahesab Calendar in first four month for both 1404 and 1405 years.
If there's a better way to share them tell me please.
first_four_months_events.zip

Copy link
Member

@sadrasabouri sadrasabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job; I reviewed them all and they are look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants