Weibull #32
Open
Weibull #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #32 +/- ##
==========================================
+ Coverage 98.07% 98.39% +0.33%
==========================================
Files 7 8 +1
Lines 155 186 +31
Branches 18 21 +3
==========================================
+ Hits 152 183 +31
Misses 2 2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sepandhaghighi
requested changes
Oct 22, 2025
CHANGELOG.md
Outdated
| ## [Unreleased] | ||
| ### Changed | ||
| - `Python 3.14` added to `test.yml` | ||
| - Weibull model |
There was a problem hiding this comment.
Please relocate this line to the ### Added section.
sepandhaghighi
requested changes
Oct 30, 2025
| model.simulate(duration=100, time_step=1) | ||
| model.plot(show=True) | ||
| ``` | ||
| <img src="./otherfiles/weibull_plot.png" alt="Weibull Plot"> |
There was a problem hiding this comment.
Please convert this link to an absolute format (https://github.com/openscilab/drux/raw/...)
|
|
||
| def _validate_parameters(self) -> None: | ||
| """Validate the parameters of the Weibull model.""" | ||
| if self._parameters.M <= 0: |
There was a problem hiding this comment.
Here, I believe we can change this line to self._parameters.M < 0. It's a bit weird, but theoretically, it is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#30
What does this implement/fix? Explain your changes.