acknowledgement of address-formatting

[freyfogle]

Hi, Ed from OpenCage here.

I am the primary maintainer of the address-formatting project.

It looks like your addresses/formats.yml came from address-formatting.

Something stopped you from acknowledging our work, as per the license. What is it?

[pudo]

Hi @freyfogle, thanks for pointing this out. I'm really embarrassed by this omission, and I want to apologize for it. The proximate cause is that this started out as a separate fork of the relevant Python library (https://github.com/pudo-attic/addressformatting), which still carried the acknowledgement - and I then sloppily inlined into rigour to do some perf work, not considering the heritage. I'll add the relevant credits later today.

Thanks for the amazing work you folks at OpenCage do :)

[freyfogle]

Thanks, I appreciate the fast and positive follow up.

Is there any way we can keep the configuration in sync?
Via sub-module or whatever?

This way we all benefit from fixes, of which there is a steady flow.

[pudo]

The problem we ran into was that all Python implementations of mustache seem to be unmaintained, and deadly slow. So the derivative file we're using now is based on Python's de-facto standard Jinja2 template lib, which compiles templates to bytecode. The net impact on some of our long-running data jobs was to halve overall runtime.

I'd love to figure out how to use the upstream worldwide.yml again, but it would probably require a sort of pre-compile translation of template languages. I'll have a think about this and see if it's something that we can do fully programmatically...

[freyfogle]

Definitely faster processing time is always nice, and the ability to have logic like if statements would be nice (though also opens the door to chaos I guess). But looking at your template, you are only using one if statement. So really it is just a matter of converting mustache's {{#first}} statements into jinga2's or statements, and then adding back your single if statement Unless I'm overlooking something (possible), it seems very doable.