Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copilot data in level4 api, and cleanups #4840

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

bloodearnest
Copy link
Member

This adds copiloted workspace data, so we can use that in airlock.

It also cleans up a few small issues, and completes the implementation of the staff field.

Fixes #4837

It's no longer needed by airlock
Added some defaults, caught some minor issues.
This will allow us to list copiloted projects for a user
This existed, and had some test set up, but was not actually set. We're
about to store user data in a persistant way in airlock, so it would be
good to have this for that purpose.
Copy link
Contributor

@Jongmassey Jongmassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One q re:

store user data in a persistant way in airlock,

What's the process for managing updates to this persisted data? I'm guessing that job server will continue to be the source of truth for user data?

@bloodearnest
Copy link
Member Author

What's the process for managing updates to this persisted data? I'm guessing that job server will continue to be the source of truth for user data?

Yes, precisely. On log in, and every 15m whilst logged in, airlock will call this API, and update our user table with whatever it tells us. Our persistent storage is just a read-only cache, really.

The main motivation here is to be able to show the full name of other users in airlock, rather than github username. See opensafely-core/airlock#443 for more

@bloodearnest bloodearnest merged commit c9e84e7 into main Feb 7, 2025
7 checks passed
@bloodearnest bloodearnest deleted the copilot-in-level4-api branch February 7, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose copiloting information in airlock API
2 participants