Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the build success by fixing groupIds for common and ssp modules. #47

Merged
merged 1 commit into from
Apr 23, 2014

Conversation

karayv
Copy link

@karayv karayv commented Aug 6, 2013

Hey!

Your build did not work with "mvn clean install". This was due to incorrect artifact group ids. So I fixed this.

Also I corrected gitignore settings.

Thanks for your project! Most likely I'll continue to contribute.

Removed redundant groupId declarations. Corrected gitignore settings.
@jm3
Copy link

jm3 commented Apr 21, 2014

Whoa, has this pull request really been sitting out here for 9 months?! 😕

@jayshao
Copy link
Collaborator

jayshao commented Apr 22, 2014

Hmm.... we may need to come up with a better workflow for reviewing changes - though I thought I checked in a similar patch...

Also - perhaps setup some CI hooks - I could probably shake-loose a public jenkins instance - or I suppose we could look at Travis or some other tool, though I've not played with them directly.

chompi added a commit that referenced this pull request Apr 23, 2014
Made the build success by fixing groupIds for common and ssp modules.
@chompi chompi merged commit c012c57 into openrtb:2.0 Apr 23, 2014
@chompi
Copy link
Collaborator

chompi commented Apr 23, 2014

Ouch! Somehow I missed it too... I am hoping we have more coverage from the community but I probably should add more admins. I am going to merge this now. I like the idea of jenkins or travis (we use jenkins for our platform builds). Will look into the same. Thanks for the alerts - much needed and appreciated.

@chompi
Copy link
Collaborator

chompi commented Apr 23, 2014

Jm3 I added you as a contributor to the openrtb2x repo.

On Mon, Apr 21, 2014 at 9:06 PM, Jason Shao notifications@github.comwrote:

Hmm.... we may need to come up with a better workflow for reviewing
changes - though I thought I checked in a similar patch...

Also - perhaps setup some CI hooks - I could probably shake-loose a public
jenkins instance - or I suppose we could look at Travis or some other tool,
though I've not played with them directly.


Reply to this email directly or view it on GitHubhttps://github.com//pull/47#issuecomment-40994019
.

Pankaj Shroff
shroffG@Gmail.com

@jm3
Copy link

jm3 commented Apr 23, 2014

@chompi thanks, yo!

@chompi
Copy link
Collaborator

chompi commented Apr 23, 2014

Youre welcome! Sorry for the delay on pull requests.

On Apr 23, 2014, at 1:53 AM, "jm3@jm3.net" notifications@github.com wrote:

@chompi thanks, yo!


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants