Fixes from tests #14
Merged
Fixes from tests #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes coming from running the tests
Cyclic import
To solve this issue, I made the less intrusive approach possible: use forward references for the extended types referenced inside the basic types file. This does not solve the underlying architectural problem though.
Contacting services on import
This solves the issue that caused the library to hang out when using anything inside the utils file. The proposed solution is trying to unblock some workflows, a better solution would be to make separated set of dependencies for the advanced use of the library, avoiding these external contacts and avoiding to install huge libraries like torch for the core usage.
Partial pydantic upgrade
In the requirements pydantic v2 was used, but some parts of the code were still in v1. The ones fixed in this PR are only the ones that were failing when running the tests.