Chore/rework custom mws #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both used to forward backend status codes when appropriate
naggingant
commented
Jul 20, 2021
go.mod
Outdated
Comment on lines
55
to
60
| replace ( | ||
| github.com/devopsfaith/krakend-amqp v1.4.0 => github.com/openrm/krakend-amqp v0.0.0-20210526165636-5cc9045b5fa6 | ||
| github.com/devopsfaith/krakend-cel v1.4.0 => github.com/openrm/krakend-cel v0.0.0-20210719101150-9ec8a72804f1 | ||
| github.com/devopsfaith/krakend-jose v1.4.0 => github.com/openrm/krakend-jose v0.0.0-20210719112350-52718b067cbd | ||
| github.com/devopsfaith/krakend-martian v1.4.0 => github.com/openrm/krakend-martian v0.0.0-20210718024057-b5801065122d | ||
| ) |
There was a problem hiding this comment.
Instead of replacing the module import declarations, I used this direction this time. Could minimize the change to the upstream, working well so far
There was a problem hiding this comment.
good idea, it will also help to replace it when doing some local testing
|
that's awesome, thank you! |
naggingant
force-pushed
the
chore/rework-custom-mws
branch
from
60e2140
to
29cc866
Compare
|
Fixed a few bugs in the AMQP module + alpha, all minor |
robjweiss
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@openrm/dev
Reworked the accumulated customization to the community edition. Below is the summary:
The main goal for me was to minimize the future work to sync the repository with the upstream, because the previous version became a complete mess IMO. This meant more separate files for the customized parts, go module replacement for our own forks, etc.