proposals: Add Errata the Machine Reference #21
Conversation
There is an error for the l.nop insn in the Section Machine Reference, fix the OPC for l.nop from 0x05 to 0x15. Signed-off-by: chenmiao <chenmiao.ku@gmail.com>
|
Thanks for spotting this. Could you find and others that do not match? |
sure, I check all the Machine Reference later |
There are some error for the insn in the Section Machine Reference, fix all the OPCs to correct OPCs. Signed-off-by: chenmiao <chenmiao.ku@gmail.com>
|
Can you change the title, "Add errata the machine reference" is not very understandable. Maybe "Fix errors in the machine reference"? |
| *the OPC for l.nop should be 0x15 instead of 0x05*. | ||
| but there is an error in the presentation of the instruction: | ||
|
|
||
| 1. *the OPC for l.nop should be 0x15 instead of 0x05*. |
There was a problem hiding this comment.
Actually I think this and the rest are right, the OPC in the machine code reference is just considering the first 5 bits of the machine instruction.
So for l.nop first 6-bits is 0b000101. which is 0x05. This is the same for all others.
In the instruction definitions section the l.nop opcode mentioned is 8-bits. But for other instructions iit may be more.
Perhaps for this errata we can just add a code to the "Machine Code Reference" that the OPC column only represents the first 6-bits of the opcode.
There was a problem hiding this comment.
yeah, if you add the code to represent the first 6-bits of opcode, there are no more questions.
There is an error for the l.nop insn in the Section Machine Reference, fix the OPC for l.nop from 0x05 to 0x15.