Skip to content

Commit

Permalink
coccinelle: Add rules to find str_false_true() replacements
Browse files Browse the repository at this point in the history
As done with str_true_false(), add checks for str_false_true()
opportunities. A simple test can find over 9 cases currently
exist in the tree.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
  • Loading branch information
Hongbo Li authored and JuliaLawall committed Sep 28, 2024
1 parent 716bf84 commit 8a0236b
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions scripts/coccinelle/api/string_choices.cocci
Original file line number Diff line number Diff line change
Expand Up @@ -104,3 +104,22 @@ e << str_true_false_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_true_false(%s)" % e)
@str_false_true depends on patch@
expression E;
@@
- ((E) ? "false" : "true")
+ str_false_true(E)

@str_false_true_r depends on !patch exists@
expression E;
position P;
@@
* ((E@P) ? "false" : "true")

@script:python depends on report@
p << str_false_true_r.P;
e << str_false_true_r.E;
@@
coccilib.report.print_report(p[0], "opportunity for str_false_true(%s)" % e)

0 comments on commit 8a0236b

Please sign in to comment.