Skip to content

Commit

Permalink
sh: fix put_user sparse errors
Browse files Browse the repository at this point in the history
virtio wants to write bitwise types to userspace using put_user.
At the moment this triggers sparse errors, since the value is passed
through an integer.

For example:

	__le32 __user *p;
	__le32 x;
	put_user(x, p);

is safe, but currently triggers a sparse warning.

Fix that up using __force.

Note: this does not suppress any useful sparse checks since caller
assigns x to typeof(*p), which in turn forces all the necessary type
checks.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
  • Loading branch information
mstsirkin committed Jan 13, 2015
1 parent 9ef8dc1 commit 66959ed
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions arch/sh/include/asm/uaccess_64.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,19 @@ do { \
switch (size) { \
case 1: \
retval = __put_user_asm_b((void *)&x, \
(long)ptr); \
(__force long)ptr); \
break; \
case 2: \
retval = __put_user_asm_w((void *)&x, \
(long)ptr); \
(__force long)ptr); \
break; \
case 4: \
retval = __put_user_asm_l((void *)&x, \
(long)ptr); \
(__force long)ptr); \
break; \
case 8: \
retval = __put_user_asm_q((void *)&x, \
(long)ptr); \
(__force long)ptr); \
break; \
default: \
__put_user_unknown(); \
Expand Down

0 comments on commit 66959ed

Please sign in to comment.