Skip to content

Commit

Permalink
bridge: add notification over netlink when STP changes state
Browse files Browse the repository at this point in the history
When STP changes state of interface need to send a new link
message to reflect that change.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
stephen hemminger authored and davem330 committed Jul 23, 2011
1 parent 56139fc commit 4ecb961
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions net/bridge/br_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,8 @@ static int br_rtm_setlink(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)

p->state = new_state;
br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);

return 0;
}

Expand Down
4 changes: 3 additions & 1 deletion net/bridge/br_stp.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,8 @@ static void br_make_blocking(struct net_bridge_port *p)

p->state = BR_STATE_BLOCKING;
br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);

del_timer(&p->forward_delay_timer);
}
}
Expand All @@ -386,8 +388,8 @@ static void br_make_forwarding(struct net_bridge_port *p)
p->state = BR_STATE_LEARNING;

br_multicast_enable_port(p);

br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);

if (br->forward_delay != 0)
mod_timer(&p->forward_delay_timer, jiffies + br->forward_delay);
Expand Down
3 changes: 3 additions & 0 deletions net/bridge/br_stp_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ void br_stp_enable_port(struct net_bridge_port *p)
br_init_port(p);
br_port_state_selection(p->br);
br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);
}

/* called under bridge lock */
Expand All @@ -104,6 +105,8 @@ void br_stp_disable_port(struct net_bridge_port *p)
p->topology_change_ack = 0;
p->config_pending = 0;

br_ifinfo_notify(RTM_NEWLINK, p);

del_timer(&p->message_age_timer);
del_timer(&p->forward_delay_timer);
del_timer(&p->hold_timer);
Expand Down
1 change: 1 addition & 0 deletions net/bridge/br_stp_timer.c
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ static void br_forward_delay_timer_expired(unsigned long arg)
netif_carrier_on(br->dev);
}
br_log_state(p);
br_ifinfo_notify(RTM_NEWLINK, p);
spin_unlock(&br->lock);
}

Expand Down

0 comments on commit 4ecb961

Please sign in to comment.