Skip to content

Commit

Permalink
ACPI: replace kmalloc+memset with kzalloc
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Burman Yan authored and lenb committed Dec 20, 2006
1 parent 5b7b411 commit 36bcbec
Show file tree
Hide file tree
Showing 22 changed files with 38 additions and 80 deletions.
4 changes: 1 addition & 3 deletions arch/ia64/kernel/cpufreq/acpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -276,12 +276,10 @@ acpi_cpufreq_cpu_init (

dprintk("acpi_cpufreq_cpu_init\n");

data = kmalloc(sizeof(struct cpufreq_acpi_io), GFP_KERNEL);
data = kzalloc(sizeof(struct cpufreq_acpi_io), GFP_KERNEL);
if (!data)
return (-ENOMEM);

memset(data, 0, sizeof(struct cpufreq_acpi_io));

acpi_io_data[cpu] = data;

result = acpi_processor_register_performance(&data->acpi_data, cpu);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/ac.c
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,9 @@ static int acpi_ac_add(struct acpi_device *device)
if (!device)
return -EINVAL;

ac = kmalloc(sizeof(struct acpi_ac), GFP_KERNEL);
ac = kzalloc(sizeof(struct acpi_ac), GFP_KERNEL);
if (!ac)
return -ENOMEM;
memset(ac, 0, sizeof(struct acpi_ac));

ac->device = device;
strcpy(acpi_device_name(device), ACPI_AC_DEVICE_NAME);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/acpi_memhotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,9 @@ static int acpi_memory_device_add(struct acpi_device *device)
if (!device)
return -EINVAL;

mem_device = kmalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
mem_device = kzalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
if (!mem_device)
return -ENOMEM;
memset(mem_device, 0, sizeof(struct acpi_memory_device));

INIT_LIST_HEAD(&mem_device->res_list);
mem_device->device = device;
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/asus_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1264,10 +1264,9 @@ static int asus_hotk_add(struct acpi_device *device)
printk(KERN_NOTICE "Asus Laptop ACPI Extras version %s\n",
ASUS_ACPI_VERSION);

hotk = kmalloc(sizeof(struct asus_hotk), GFP_KERNEL);
hotk = kzalloc(sizeof(struct asus_hotk), GFP_KERNEL);
if (!hotk)
return -ENOMEM;
memset(hotk, 0, sizeof(struct asus_hotk));

hotk->handle = device->handle;
strcpy(acpi_device_name(device), ACPI_HOTK_DEVICE_NAME);
Expand Down
9 changes: 3 additions & 6 deletions drivers/acpi/battery.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,12 +160,11 @@ acpi_battery_get_info(struct acpi_battery *battery,
goto end;
}

data.pointer = kmalloc(data.length, GFP_KERNEL);
data.pointer = kzalloc(data.length, GFP_KERNEL);
if (!data.pointer) {
result = -ENOMEM;
goto end;
}
memset(data.pointer, 0, data.length);

status = acpi_extract_package(package, &format, &data);
if (ACPI_FAILURE(status)) {
Expand Down Expand Up @@ -220,12 +219,11 @@ acpi_battery_get_status(struct acpi_battery *battery,
goto end;
}

data.pointer = kmalloc(data.length, GFP_KERNEL);
data.pointer = kzalloc(data.length, GFP_KERNEL);
if (!data.pointer) {
result = -ENOMEM;
goto end;
}
memset(data.pointer, 0, data.length);

status = acpi_extract_package(package, &format, &data);
if (ACPI_FAILURE(status)) {
Expand Down Expand Up @@ -694,10 +692,9 @@ static int acpi_battery_add(struct acpi_device *device)
if (!device)
return -EINVAL;

battery = kmalloc(sizeof(struct acpi_battery), GFP_KERNEL);
battery = kzalloc(sizeof(struct acpi_battery), GFP_KERNEL);
if (!battery)
return -ENOMEM;
memset(battery, 0, sizeof(struct acpi_battery));

battery->device = device;
strcpy(acpi_device_name(device), ACPI_BATTERY_DEVICE_NAME);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/container.c
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,10 @@ static int acpi_container_add(struct acpi_device *device)
return -EINVAL;
}

container = kmalloc(sizeof(struct acpi_container), GFP_KERNEL);
container = kzalloc(sizeof(struct acpi_container), GFP_KERNEL);
if (!container)
return -ENOMEM;

memset(container, 0, sizeof(struct acpi_container));
container->handle = device->handle;
strcpy(acpi_device_name(device), ACPI_CONTAINER_DEVICE_NAME);
strcpy(acpi_device_class(device), ACPI_CONTAINER_CLASS);
Expand Down
9 changes: 3 additions & 6 deletions drivers/acpi/ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -624,10 +624,9 @@ static int acpi_ec_add(struct acpi_device *device)
if (!device)
return -EINVAL;

ec = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
ec = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
if (!ec)
return -ENOMEM;
memset(ec, 0, sizeof(struct acpi_ec));

ec->handle = device->handle;
ec->uid = -1;
Expand Down Expand Up @@ -848,12 +847,11 @@ static int __init acpi_ec_fake_ecdt(void)

ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Try to make an fake ECDT"));

ec_ecdt = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
ec_ecdt = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
if (!ec_ecdt) {
ret = -ENOMEM;
goto error;
}
memset(ec_ecdt, 0, sizeof(struct acpi_ec));

status = acpi_get_devices(ACPI_EC_HID,
acpi_fake_ecdt_callback, NULL, NULL);
Expand Down Expand Up @@ -885,10 +883,9 @@ static int __init acpi_ec_get_real_ecdt(void)
/*
* Generate a temporary ec context to use until the namespace is scanned
*/
ec_ecdt = kmalloc(sizeof(struct acpi_ec), GFP_KERNEL);
ec_ecdt = kzalloc(sizeof(struct acpi_ec), GFP_KERNEL);
if (!ec_ecdt)
return -ENOMEM;
memset(ec_ecdt, 0, sizeof(struct acpi_ec));

mutex_init(&ec_ecdt->lock);
if (acpi_ec_mode == EC_INTR) {
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/fan.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,10 +186,9 @@ static int acpi_fan_add(struct acpi_device *device)
if (!device)
return -EINVAL;

fan = kmalloc(sizeof(struct acpi_fan), GFP_KERNEL);
fan = kzalloc(sizeof(struct acpi_fan), GFP_KERNEL);
if (!fan)
return -ENOMEM;
memset(fan, 0, sizeof(struct acpi_fan));

fan->device = device;
strcpy(acpi_device_name(device), "Fan");
Expand Down
6 changes: 2 additions & 4 deletions drivers/acpi/i2c_ec.c
Original file line number Diff line number Diff line change
Expand Up @@ -309,18 +309,16 @@ static int acpi_ec_hc_add(struct acpi_device *device)
return -EINVAL;
}

ec_hc = kmalloc(sizeof(struct acpi_ec_hc), GFP_KERNEL);
ec_hc = kzalloc(sizeof(struct acpi_ec_hc), GFP_KERNEL);
if (!ec_hc) {
return -ENOMEM;
}
memset(ec_hc, 0, sizeof(struct acpi_ec_hc));

smbus = kmalloc(sizeof(struct acpi_ec_smbus), GFP_KERNEL);
smbus = kzalloc(sizeof(struct acpi_ec_smbus), GFP_KERNEL);
if (!smbus) {
kfree(ec_hc);
return -ENOMEM;
}
memset(smbus, 0, sizeof(struct acpi_ec_smbus));

ec_hc->handle = device->handle;
strcpy(acpi_device_name(device), ACPI_EC_HC_DEVICE_NAME);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/ibm_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -2516,13 +2516,12 @@ static int __init register_driver(struct ibm_struct *ibm)
{
int ret;

ibm->driver = kmalloc(sizeof(struct acpi_driver), GFP_KERNEL);
ibm->driver = kzalloc(sizeof(struct acpi_driver), GFP_KERNEL);
if (!ibm->driver) {
printk(IBM_ERR "kmalloc(ibm->driver) failed\n");
return -1;
}

memset(ibm->driver, 0, sizeof(struct acpi_driver));
sprintf(ibm->driver->name, "%s_%s", IBM_NAME, ibm->name);
ibm->driver->ids = ibm->hid;
ibm->driver->ops.add = &ibm_device_add;
Expand Down
16 changes: 5 additions & 11 deletions drivers/acpi/pci_bind.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,19 +122,17 @@ int acpi_pci_bind(struct acpi_device *device)
if (!device || !device->parent)
return -EINVAL;

pathname = kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
pathname = kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
if (!pathname)
return -ENOMEM;
memset(pathname, 0, ACPI_PATHNAME_MAX);
buffer.length = ACPI_PATHNAME_MAX;
buffer.pointer = pathname;

data = kmalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
data = kzalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
if (!data) {
kfree(pathname);
return -ENOMEM;
}
memset(data, 0, sizeof(struct acpi_pci_data));

acpi_get_name(device->handle, ACPI_FULL_PATHNAME, &buffer);
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "Binding PCI device [%s]...\n",
Expand Down Expand Up @@ -281,10 +279,9 @@ int acpi_pci_unbind(struct acpi_device *device)
if (!device || !device->parent)
return -EINVAL;

pathname = kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
pathname = kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
if (!pathname)
return -ENOMEM;
memset(pathname, 0, ACPI_PATHNAME_MAX);

buffer.length = ACPI_PATHNAME_MAX;
buffer.pointer = pathname;
Expand Down Expand Up @@ -331,11 +328,9 @@ acpi_pci_bind_root(struct acpi_device *device,
char *pathname = NULL;
struct acpi_buffer buffer = { 0, NULL };


pathname = kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
pathname = kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
if (!pathname)
return -ENOMEM;
memset(pathname, 0, ACPI_PATHNAME_MAX);

buffer.length = ACPI_PATHNAME_MAX;
buffer.pointer = pathname;
Expand All @@ -345,12 +340,11 @@ acpi_pci_bind_root(struct acpi_device *device,
return -EINVAL;
}

data = kmalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
data = kzalloc(sizeof(struct acpi_pci_data), GFP_KERNEL);
if (!data) {
kfree(pathname);
return -ENOMEM;
}
memset(data, 0, sizeof(struct acpi_pci_data));

data->id = *id;
data->bus = bus;
Expand Down
9 changes: 3 additions & 6 deletions drivers/acpi/pci_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,9 @@ acpi_pci_irq_add_entry(acpi_handle handle,
if (!prt)
return -EINVAL;

entry = kmalloc(sizeof(struct acpi_prt_entry), GFP_KERNEL);
entry = kzalloc(sizeof(struct acpi_prt_entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;
memset(entry, 0, sizeof(struct acpi_prt_entry));

entry->id.segment = segment;
entry->id.bus = bus;
Expand Down Expand Up @@ -161,10 +160,9 @@ int acpi_pci_irq_add_prt(acpi_handle handle, int segment, int bus)
static int first_time = 1;


pathname = kmalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
pathname = kzalloc(ACPI_PATHNAME_MAX, GFP_KERNEL);
if (!pathname)
return -ENOMEM;
memset(pathname, 0, ACPI_PATHNAME_MAX);

if (first_time) {
acpi_prt.count = 0;
Expand Down Expand Up @@ -198,11 +196,10 @@ int acpi_pci_irq_add_prt(acpi_handle handle, int segment, int bus)
return -ENODEV;
}

prt = kmalloc(buffer.length, GFP_KERNEL);
prt = kzalloc(buffer.length, GFP_KERNEL);
if (!prt) {
return -ENOMEM;
}
memset(prt, 0, buffer.length);
buffer.pointer = prt;

status = acpi_get_irq_routing_table(handle, &buffer);
Expand Down
6 changes: 2 additions & 4 deletions drivers/acpi/pci_link.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,11 +307,10 @@ static int acpi_pci_link_set(struct acpi_pci_link *link, int irq)
if (!link || !irq)
return -EINVAL;

resource = kmalloc(sizeof(*resource) + 1, irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
resource = kzalloc(sizeof(*resource) + 1, irqs_disabled() ? GFP_ATOMIC: GFP_KERNEL);
if (!resource)
return -ENOMEM;

memset(resource, 0, sizeof(*resource) + 1);
buffer.length = sizeof(*resource) + 1;
buffer.pointer = resource;

Expand Down Expand Up @@ -718,10 +717,9 @@ static int acpi_pci_link_add(struct acpi_device *device)
if (!device)
return -EINVAL;

link = kmalloc(sizeof(struct acpi_pci_link), GFP_KERNEL);
link = kzalloc(sizeof(struct acpi_pci_link), GFP_KERNEL);
if (!link)
return -ENOMEM;
memset(link, 0, sizeof(struct acpi_pci_link));

link->device = device;
strcpy(acpi_device_name(device), ACPI_PCI_LINK_DEVICE_NAME);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/pci_root.c
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,9 @@ static int acpi_pci_root_add(struct acpi_device *device)
if (!device)
return -EINVAL;

root = kmalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
root = kzalloc(sizeof(struct acpi_pci_root), GFP_KERNEL);
if (!root)
return -ENOMEM;
memset(root, 0, sizeof(struct acpi_pci_root));
INIT_LIST_HEAD(&root->node);

root->device = device;
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/power.c
Original file line number Diff line number Diff line change
Expand Up @@ -532,10 +532,9 @@ static int acpi_power_add(struct acpi_device *device)
if (!device)
return -EINVAL;

resource = kmalloc(sizeof(struct acpi_power_resource), GFP_KERNEL);
resource = kzalloc(sizeof(struct acpi_power_resource), GFP_KERNEL);
if (!resource)
return -ENOMEM;
memset(resource, 0, sizeof(struct acpi_power_resource));

resource->device = device;
strcpy(resource->name, device->pnp.bus_id);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/processor_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -615,10 +615,9 @@ static int acpi_processor_add(struct acpi_device *device)
if (!device)
return -EINVAL;

pr = kmalloc(sizeof(struct acpi_processor), GFP_KERNEL);
pr = kzalloc(sizeof(struct acpi_processor), GFP_KERNEL);
if (!pr)
return -ENOMEM;
memset(pr, 0, sizeof(struct acpi_processor));

pr->handle = device->handle;
strcpy(acpi_device_name(device), ACPI_PROCESSOR_DEVICE_NAME);
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/sbs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1576,12 +1576,11 @@ static int acpi_sbs_add(struct acpi_device *device)
int id, cnt;
acpi_status status = AE_OK;

sbs = kmalloc(sizeof(struct acpi_sbs), GFP_KERNEL);
sbs = kzalloc(sizeof(struct acpi_sbs), GFP_KERNEL);
if (!sbs) {
ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "kmalloc() failed\n"));
return -ENOMEM;
}
memset(sbs, 0, sizeof(struct acpi_sbs));

cnt = 0;
while (cnt < 10) {
Expand Down
3 changes: 1 addition & 2 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -984,12 +984,11 @@ acpi_add_single_object(struct acpi_device **child,
if (!child)
return -EINVAL;

device = kmalloc(sizeof(struct acpi_device), GFP_KERNEL);
device = kzalloc(sizeof(struct acpi_device), GFP_KERNEL);
if (!device) {
printk(KERN_ERR PREFIX "Memory allocation error\n");
return -ENOMEM;
}
memset(device, 0, sizeof(struct acpi_device));

device->handle = handle;
device->parent = parent;
Expand Down
Loading

0 comments on commit 36bcbec

Please sign in to comment.