Skip to content

Commit

Permalink
knfsd: nfsd4: fix NFSv4 filehandle size units confusion
Browse files Browse the repository at this point in the history
NFS4_FHSIZE is measured in bytes, not 4-byte words, so much more space than
necessary is being allocated for struct nfs4_cb_recall.

I should have wondered why this structure was so much larger than it needed to
be!

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
bfields authored and Linus Torvalds committed Jul 17, 2007
1 parent 9a8db97 commit 33a1060
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/linux/nfsd/state.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ struct nfs4_cb_recall {
int cbr_trunc;
stateid_t cbr_stateid;
u32 cbr_fhlen;
u32 cbr_fhval[NFS4_FHSIZE];
char cbr_fhval[NFS4_FHSIZE];
struct nfs4_delegation *cbr_dp;
};

Expand Down

0 comments on commit 33a1060

Please sign in to comment.