Skip to content

Commit

Permalink
[PATCH] x86-64/i386: Don't process APICs/IO-APICs in ACPI when APIC i…
Browse files Browse the repository at this point in the history
…s disabled.

When nolapic was passed or the local APIC was disabled
for another reason ACPI would still parse the IO-APICs
until these were explicitely disabled with noapic.

Usually this resulted in a non booting configuration unless
"nolapic noapic" was used.

I also disabled the local APIC parsing in this case, although
that's only cosmetic (suppresses a few printks)

This hopefully makes nolapic work in all cases.

Cc: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Apr 11, 2006
1 parent 88dd9c1 commit 0fcd270
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion arch/i386/kernel/acpi/boot.c
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ int __init acpi_parse_mcfg(unsigned long phys_addr, unsigned long size)
unsigned long i;
int config_size;

if (!phys_addr || !size)
if (!phys_addr || !size || !cpu_has_apic)
return -EINVAL;

mcfg = (struct acpi_table_mcfg *)__acpi_map_table(phys_addr, size);
Expand Down Expand Up @@ -693,6 +693,9 @@ static int __init acpi_parse_madt_lapic_entries(void)
{
int count;

if (!cpu_has_apic)
return -ENODEV;

/*
* Note that the LAPIC address is obtained from the MADT (32-bit value)
* and (optionally) overriden by a LAPIC_ADDR_OVR entry (64-bit value).
Expand Down

0 comments on commit 0fcd270

Please sign in to comment.