Skip to content

Commit

Permalink
sony-laptop: call sonypi_compat_init earlier
Browse files Browse the repository at this point in the history
sonypi_compat uses a kfifo that needs to be present before _SRS is
called to be able to cope with the IRQs triggered when setting
resources.

Signed-off-by: Mattia Dongili <malattia@linux.it>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
malattia authored and lenb committed Aug 24, 2007
1 parent f46d160 commit 015a916
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions drivers/misc/sony-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -2317,8 +2317,6 @@ static int sony_pic_remove(struct acpi_device *device, int type)
struct sony_pic_ioport *io, *tmp_io;
struct sony_pic_irq *irq, *tmp_irq;

sonypi_compat_exit();

if (sony_pic_disable(device)) {
printk(KERN_ERR DRV_PFX "Couldn't disable device.\n");
return -ENXIO;
Expand All @@ -2328,6 +2326,8 @@ static int sony_pic_remove(struct acpi_device *device, int type)
release_region(spic_dev.cur_ioport->io.minimum,
spic_dev.cur_ioport->io.address_length);

sonypi_compat_exit();

sony_laptop_remove_input();

/* pf attrs */
Expand Down Expand Up @@ -2393,6 +2393,9 @@ static int sony_pic_add(struct acpi_device *device)
goto err_free_resources;
}

if (sonypi_compat_init())
goto err_remove_input;

/* request io port */
list_for_each_entry(io, &spic_dev.ioports, list) {
if (request_region(io->io.minimum, io->io.address_length,
Expand All @@ -2407,7 +2410,7 @@ static int sony_pic_add(struct acpi_device *device)
if (!spic_dev.cur_ioport) {
printk(KERN_ERR DRV_PFX "Failed to request_region.\n");
result = -ENODEV;
goto err_remove_input;
goto err_remove_compat;
}

/* request IRQ */
Expand Down Expand Up @@ -2447,9 +2450,6 @@ static int sony_pic_add(struct acpi_device *device)
if (result)
goto err_remove_pf;

if (sonypi_compat_init())
goto err_remove_pf;

return 0;

err_remove_pf:
Expand All @@ -2465,6 +2465,9 @@ static int sony_pic_add(struct acpi_device *device)
release_region(spic_dev.cur_ioport->io.minimum,
spic_dev.cur_ioport->io.address_length);

err_remove_compat:
sonypi_compat_exit();

err_remove_input:
sony_laptop_remove_input();

Expand Down

0 comments on commit 015a916

Please sign in to comment.