Skip to content

JavaScript: Colorize pattern matching debug output #6316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

JavaScript: Colorize pattern matching debug output #6316

wants to merge 6 commits into from

Conversation

@knutwannheden
Copy link
Contributor

@knutwannheden knutwannheden commented Nov 20, 2025 •
edited
Loading

  • Extract debug logging functionality from comparator into dedicated debug.ts module (~800 LOC)
  • Introduce JTree type union for all LST node types to improve type safety across comparators
  • Add generic type parameters to mismatch methods to preserve type information
  • Improve cursor positioning in constraint evaluation by using actual target elements
  • Fix container printing order (markers now printed after closing delimiter)
image

@knutwannheden
Pattern debugging colors
ba950fc
@knutwannheden
Polish
aebf384
@knutwannheden
Capture emojis
24b695c
@knutwannheden
Merge branch 'main' into debug-colors
5977eee 
# Conflicts:
#	rewrite-javascript/rewrite/fixtures/change-text.ts
#	rewrite-javascript/rewrite/src/javascript/templating/comparator.ts
#	rewrite-javascript/rewrite/src/javascript/templating/pattern.ts
#	rewrite-javascript/rewrite/src/javascript/templating/template.ts
@knutwannheden
Fix merge conflicts
4750fc8
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@knutwannheden knutwannheden

Labels

None yet

Projects

OpenRewrite
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knutwannheden