Skip to content

Conversation

@Anmol202005
Copy link
Contributor

@Anmol202005 Anmol202005 commented Nov 14, 2025

Improves AddMethodParameter so that methodPattern resolution includes overridden methods from interfaces and superclasses.

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Anmol202005
Copy link
Contributor Author

@timtebeek kindly review :)

@timtebeek timtebeek self-requested a review November 14, 2025 18:50
@timtebeek timtebeek added the enhancement New feature or request label Nov 14, 2025
@timtebeek
Copy link
Member

Thanks for the runnable example! I'm off here today, but will try to circle back next week.

I had thought we could clear this up with just changing the expected method pattern instead.

@Anmol202005
Copy link
Contributor Author

ping @timtebeek

@timtebeek
Copy link
Member

Will likely move into next week before I can get to this; I've got some online trainings to give and a weekend ahead first. 🙏🏻

@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Ready to Review

Development

Successfully merging this pull request may close these issues.

Allow AddMethodParameter to operate on overridden methods

2 participants