Fix UpgradePluginVersion to handle plugins with 'apply false' #6269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isPluginVersion()to walk up the entire method invocation chain to find theplugins()methodapply falsewas betweenversion()andplugins()id(...) version "x.y.z" apply falseTesting
Added test coverage for both DSLs:
kotlinDslWithApplyFalse: Tests Kotlin DSL with apply falsegroovyDslWithApplyFalse: Tests Groovy DSL with apply falseBefore
plugins { id("com.github.johnrengelman.shadow") version "7.1.0" apply false }No upgrade happened ❌
After
plugins { id("com.github.johnrengelman.shadow") version "7.1.2" apply false }Successfully upgraded ✅
Root Cause
The method invocation chain with
apply falseis:The previous implementation only checked one level up from
version(), findingapply()instead ofplugins().Technical Details
Changed in
UpgradePluginVersion.java:116-141:plugins()or reaching the rootapply()